alphard/ComfyUI-Lora-Manager
1
0
Fork 0
mirror of https://github.com/willmiao/ComfyUI-Lora-Manager.git synced 2026-08-20 04:21:27 -03:00
Code Issues Packages Projects Releases Wiki Activity

fix(download): hide URL step when file dialog opens from versions tab (#1058)

Browse Source
This commit is contained in:
Will Miao
2026-08-19 18:35:16 +08:00
parent e7c26bf722
commit 96376e5cce
2 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
static/js/managers/DownloadManager.js
+4 -1
View File
@@ -785,7 +785,10 @@ export class DownloadManager {
(version.downloadedFiles || []).map(f => String(f.fileId))
);
document.getElementById('versionStep').style.display = 'none';
// Hide every other step — this dialog can be entered directly from
// entry points like ModelVersionsTab, where the URL step would
// otherwise remain visible (#1058).
document.querySelectorAll('.download-step').forEach(step => step.style.display = 'none');
document.getElementById('fileSelectionStep').style.display = 'block';
const nameEl = document.getElementById('fileSelectionVersionName');
tests/frontend/managers/downloadManager.multiSelect.test.js
+15
View File
@@ -314,4 +314,19 @@ describe('DownloadManager multi-select file dialog (#1058)', () => {
const nextButton = document.getElementById('nextFromVersion');
expect(nextButton.disabled).toBe(true);
});
it('hides every other step (including the URL step) when the file dialog shows', () => {
// Regression: entering via openFileSelectionForVersion (ModelVersionsTab)
// left the URL step visible alongside the file selection step (#1058).
const manager = new DownloadManager();
manager.versions = [makeMultiFileVersion()];
document.getElementById('urlStep').style.display = 'block';
document.getElementById('versionStep').style.display = 'block';
manager.showFileSelectionStep('201');
expect(document.getElementById('urlStep').style.display).toBe('none');
expect(document.getElementById('versionStep').style.display).toBe('none');
expect(document.getElementById('fileSelectionStep').style.display).toBe('block');
});
});