mirror of
https://github.com/willmiao/ComfyUI-Lora-Manager.git
synced 2026-10-12 04:22:13 -03:00
Will Miao
5976224d75
Deleting a folder that holds models answered "A deletion is still pending inside this folder. Wait for the undo window to expire." even though nothing was staged and no window was running. `.lm-pending-delete` is only a container: the purge, the undo and the staging rollback all removed the batch dir inside it and left the container behind, and the folder manifest matched the directory *name* alone. Any folder where a model had ever been deleted with the undo window was therefore undeletable for good, and the same name match refused folder renames. * `staging_dir_has_content()` is the shared answer to "is there still a batch here?": an empty container is a leftover, a quarantined batch (`*.orphaned`) is preserved data and still counts, and an unreadable directory counts too — never delete over something that could not be listed. * The container is removed with its last batch (purge, undo, staging rollback, merged-loser cleanup). `rmdir` only ever succeeds on an empty directory, and the path is checked to really be a `.lm-pending-delete`, so a model folder is never at risk. * A manifest-less batch dir with nothing in it is a crash leftover between `makedirs` and the manifest write: it is dropped instead of quarantined, which would have left an empty container that blocks deletion just the same. Verified: purge, undo and the empty-manifest-less sweep all leave no container behind, the container survives while another batch is staged, and an empty one no longer blocks folder delete or rename while a real (or quarantined) batch still does. 3818 backend tests pass.