mirror of
https://github.com/willmiao/ComfyUI-Lora-Manager.git
synced 2026-09-21 03:01:27 -03:00
Will Miao
84146b62fd
Other Models management is opt-in and its folders come from folder_paths.get_folder_paths(). In plugin mode ComfyUI registers vae, upscale_models, text_encoders, clip_vision and controlnet out of the box, so enabling the feature works immediately. Standalone only knows the keys present in settings.json.folder_paths, and that file is edited by hand - there is no UI for those keys - so a standalone user who followed the announcement banner reached "Enable Other Models" and then an empty page. Gate the announcement on the capability instead of on how the process was started: - Config.get_other_models_availability() probes every canonical other key (legacy clip collapses into text_encoders where the host exposes map_legacy) and reports which sub_types resolve to a folder that exists on disk. It deliberately ignores enable_other_models: the question is "could this work here at all?". An empty folder counts, because CivitAI downloads can target it. - /api/lm/settings exposes it as the derived, non-persisted other_models_paths_available flag; a probe failure yields null and the banner fails open. - BannerService only registers the announcement when the flag is not false. `=== false` (not falsy) keeps a cached/older payload working, and nothing is written to dismissed_banners, so the banner can return once folders exist. - The Other page grows an "enabled but nothing to scan" empty state driven by config.other_roots, showing the settings.json snippet for standalone and a pointer to ComfyUI model paths otherwise, plus an Open Settings action. It also covers the corner where only a non-default sub_type has a folder. Translate the six other.noPaths.* keys into all nine locales and record the new "folder key" / "on disk" terminology in the i18n guidelines. Backend tests and pytest tests/i18n could not run in this environment (no pytest/platformdirs); the probe was exercised against a stubbed folder_paths. Frontend: 120 files / 1101 JS tests passed.
54 lines
1.9 KiB
JavaScript
54 lines
1.9 KiB
JavaScript
import { appCore } from './core.js';
|
|
import { showToast } from './utils/uiHelpers.js';
|
|
import { enableOtherModels, openOtherModelsSettings } from './utils/otherModels.js';
|
|
|
|
/**
|
|
* Other Models is an opt-in feature. While it is disabled this page renders an
|
|
* empty state whose button turns the feature on; the backend then rebuilds the
|
|
* other-model roots and starts scanning, so a reload lands on the real page.
|
|
*
|
|
* The same module backs the "enabled but no folders found" state, where the
|
|
* only useful action is jumping to Settings instead of enabling anything.
|
|
*/
|
|
async function handleEnableClick() {
|
|
const button = document.getElementById('enableOtherModelsBtn');
|
|
if (!button || button.disabled) return;
|
|
|
|
button.disabled = true;
|
|
try {
|
|
await enableOtherModels();
|
|
} catch (error) {
|
|
button.disabled = false;
|
|
showToast('other.disabled.enableFailed', { message: error.message }, 'error');
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Open Settings on the Library section for the "no folders found" state, so a
|
|
* misconfigured install can be fixed without hand-editing unknown keys.
|
|
*/
|
|
function handleOpenSettingsClick(event) {
|
|
event.preventDefault();
|
|
openOtherModelsSettings();
|
|
}
|
|
|
|
async function initializeOtherDisabledPage() {
|
|
// appCore.initialize() wires the shared header (theme, settings modal,
|
|
// language) so this page is not a dead end.
|
|
await appCore.initialize();
|
|
|
|
const button = document.getElementById('enableOtherModelsBtn');
|
|
if (button) {
|
|
button.addEventListener('click', handleEnableClick);
|
|
}
|
|
|
|
const settingsButton = document.getElementById('openOtherModelsSettingsBtn');
|
|
if (settingsButton) {
|
|
settingsButton.addEventListener('click', handleOpenSettingsClick);
|
|
}
|
|
}
|
|
|
|
document.addEventListener('DOMContentLoaded', initializeOtherDisabledPage);
|
|
|
|
export { handleEnableClick as enableOtherModels, initializeOtherDisabledPage };
|