A model file could only ever be linked to huggingface.co: `set_hf_url` validated the URL with a huggingface-only regex, the agent fetched the card from a hardcoded HF URL, and the readme processor built every relative image path off `https://huggingface.co/{repo}/resolve/main`. ModelScope publishes the same model-card convention (README.md + YAML frontmatter, often carrying `base_model:` and `trigger_words:`) behind a public, key-less API, so the enrichment pipeline could already serve it - it was the plumbing that was HF-shaped, not the idea. Make the external source a first-class, provider-driven concept: - New `py/services/model_sources/` registry. A `ModelSource` owns URL recognition (lenient for stored values, strict for user input), the canonical page URL, model-card fetching, the asset base URL and the capability flags. `HuggingFaceSource` is the previous logic relocated; `ModelScopeSource` reads `/models/{o}/{n}/resolve/{master|main}/README.md` and falls back to `/api/v1/models/{o}/{n}/repo`. `TensorArtSource` is link-only on purpose: tensor.art answers plain HTTP clients with a Cloudflare challenge and its internal API (ap-east-1.tensorart.cloud / cn.tensorart.net) rejects every /v1/model/* route with "invalid authorization header", so it declares supports_enrichment=False rather than failing silently later. - Metadata gains `source_platform` + `source_url`; `hf_url` stays as a read/write alias, written only for Hugging Face, so existing sidecars, cached rows and third-party consumers keep working. Normalisation runs at the scanner, the persistent cache (both directions, plus two new columns behind an ALTER migration) and the linking handler - which is what stops a user who switches sources from leaving a stale `hf_url` on a ModelScope model. - The agent pipeline keys off the provider instead of `hf_url`: the fast-fail gate now explains *why* a model is skipped (no source / unknown source / source without a reachable card), the prompt context exposes source_url/source_id/source_label/asset_base_url while still filling the legacy hf_url/repo aliases, and the four README image extractors take a base_url (defaulting to HF) so relative paths resolve against the right site. Version grouping generalises to hf: / ms: / ta: keys. - `POST /api/lm/set-hf-url` keeps its path and its legacy payload keys but accepts `source_url`, validates against every provider and returns the platform. `GET /api/lm/model-sources` lets the UI render the supported-site list from the server. - Frontend: a `modelSourceHelpers` mirror of the registry drives the link dialog, the card/modal globe (branded "View on ModelScope/TensorArt"), the version-group key and the enrichment gate; the versions tab no longer sends ms:/ta: keys to the CivitAI API. TensorArt stays in the list because provenance is worth keeping even when the card is unreadable - the dialog says so plainly ("Sites that don't expose one (currently TensorArt) can only be linked") and the context menu disables enrichment with a matching tooltip, instead of the user getting "Unsupported URL". Verified against the real ModelScope API: jj3550945163/Krea-2-LORA returns a 1882-byte card whose frontmatter carries base_model/tags/trigger_words, and relative images resolve to .../resolve/master/.... Tests: backend 2815 passed; frontend 1130 JS + 91 Vue passed; pytest tests/i18n and a Jinja compile pass over templates/. The nine locales carry [TODO: Translate] for the new strings, completed in the next commit.
8.7 KiB
Agent Skills System
The LoRA Manager agent skills system enables LLM-powered metadata enrichment and other AI-driven tasks. Users configure their own LLM provider (BYOK), and skills are executed through right-click context menu actions.
Architecture
┌──────────────────────────────────────────────┐
│ LoRA Manager Backend │
│ │
│ ┌──────────────┐ ┌────────────────┐ │
│ │ LLMService │───▶│ LLM Provider │ │
│ │ (BYOK config, │◀───│ (OpenAI/Ollama │ │
│ │ API calls) │ │ /custom) │ │
│ └───────┬───────┘ └────────────────┘ │
│ │ │
│ ┌───────▼───────────────────────┐ │
│ │ AgentService │ │
│ │ (orchestration: validate │ │
│ │ → LLM call → post-process │ │
│ │ → WebSocket broadcast) │ │
│ └───────┬───────────────────────┘ │
│ │ │
│ ┌───────▼───────────────────────┐ │
│ │ SkillRegistry │ │
│ │ ┌─────────────────────────┐ │ │
│ │ │ enrich_hf_metadata: │ │ │
│ │ │ - skill.yaml │ │ │
│ │ │ - prompt.md │ │ │
│ │ │ - handler.py │ │ │
│ │ └─────────────────────────┘ │ │
│ └───────────────────────────────┘ │
└──────────────────────────────────────────────┘
Key Design Principle
Skills define what to do (prompt + post-processing). The AgentService handles how (LLM calls, validation, progress).
Skills never call the LLM directly. This keeps BYOK configuration centralized and provider-agnostic.
BYOK Configuration
Users configure their LLM provider in Settings → AI Provider:
| Setting | Description | Example |
|---|---|---|
llm_provider |
Provider type | openai, ollama, or custom |
llm_api_key |
API key (not needed for local Ollama) | sk-... |
llm_api_base |
Custom API base URL (empty = provider default) | https://api.openai.com/v1 |
llm_model |
Model name | gpt-4o-mini |
Environment variable overrides: LLM_API_KEY, LLM_MODEL, LLM_API_BASE, LLM_PROVIDER.
Supported Providers
- OpenAI: Uses
https://api.openai.com/v1by default - Ollama (local): Uses
http://localhost:11434/v1, no API key required - Custom: Any OpenAI-compatible endpoint (vLLM, LM Studio, etc.) — set
llm_api_baseexplicitly
Available Skills
enrich_hf_metadata
Enriches models linked to an external model site with metadata extracted by an LLM from the site's model card (README).
Entry point: Right-click context menu → "Enrich Metadata with AI"
Supported model sources:
| Platform | Link | AI enrichment | Direct download |
|---|---|---|---|
| Hugging Face | yes | yes | yes |
| ModelScope | yes | yes | no |
| TensorArt | yes | no (see below) | no |
TensorArt is link-only: tensor.art sits behind a Cloudflare managed challenge and its internal API requires session authorization, so the backend cannot read its model pages. Linking still stores the canonical page URL and the "View on TensorArt" link works.
What it does:
- Reads the model's
.metadata.jsonto get the source (source_platform+source_url, or the legacyhf_url) - Fetches the model card through the provider in
py/services/model_sources/ - Sends the README + local metadata to the LLM for structured extraction
- Writes extracted fields to
.metadata.json:base_model— only if current value is emptytrainedWords— trigger words (LoRA only, if none exist)modelDescription— concise summary (if none exists)tags— merged with existing tags, deduplicatedmetadata_source— audit trail:agent:enrich_hf_metadatallm_enriched_at— ISO timestamp
- Downloads and optimizes preview image (if LLM found one in the README)
- Updates the scanner cache
- Broadcasts WebSocket progress events
Models with no source, an unknown source, or a source without model-card access (TensorArt) are skipped with an explicit reason and counted in the run summary.
Model types: LoRA, Checkpoint, Embedding
Adding a New Skill
1. Create the skill directory
py/services/agent/skills/<skill_name>/
├── skill.yaml # Skill metadata and schemas
├── prompt.md # LLM prompt template
└── handler.py # Pre-processing and post-processing
2. Write skill.yaml
name: my_skill
title: "My Skill"
description: "What this skill does"
llm_required: true
model_type_filter: ["lora"] # or null for all types
input_schema:
type: object
properties:
model_paths:
type: array
items:
type: string
required:
- model_paths
output_schema:
type: object
properties:
# ... JSON schema for LLM output
permissions:
write_metadata: true
write_previews: false
network_domains:
- "example.com"
3. Write prompt.md
Use {{variable}} placeholders that will be replaced with data from the prepare function:
You are an expert assistant...
Model URL: {{source_url}}
README content:
{{readme_content}}
Current metadata:
{{current_metadata}}
4. Write handler.py
async def prepare(model_path: str, input_data: dict) -> dict:
"""Gather context for the LLM prompt. Returns variables for template rendering."""
return {
"model_path": model_path,
# ... other variables used in prompt.md
}
async def post_process(context) -> dict:
"""Apply the LLM-extracted data to the model."""
llm_response = context.llm_response
# ... write metadata, download previews, update cache
return {
"success": True,
"updated_fields": ["base_model", "tags"],
"errors": [],
}
Important: Use absolute imports (from py.utils.metadata_manager import MetadataManager) because skills are loaded via importlib.util.spec_from_file_location, which doesn't support relative imports.
5. Test
The skill is automatically discovered by SkillRegistry on startup. Test with:
pytest tests/services/test_agent_service.py
API Endpoints
| Method | Path | Description |
|---|---|---|
| GET | /api/lm/agent/skills |
List available skills |
| POST | /api/lm/agent/execute/{skill_name} |
Execute a skill (body: {"model_paths": [...]}) |
| POST | /api/lm/agent/cancel |
Cancel running skill (stub) |
WebSocket Events
| Type | When | Key fields |
|---|---|---|
agent_progress |
Skill started/processing | skill, status, total, processed, success, current_path |
agent_progress |
Skill completed | skill, status, updated_models, errors, summary |
agent_progress |
Skill error | skill, status, error |
Security Model
Skills declare permissions in skill.yaml:
write_metadata— can write.metadata.jsonfileswrite_previews— can download/replace preview imagesnetwork_domains— allowed domains for HTTP requests
These are declarative constraints checked by AgentService. They are defense-in-depth, not a sandbox — the Python process can technically do anything, but the contract is clear and auditable.
File Locations
| Component | Path |
|---|---|
| LLMService | py/services/llm_service.py |
| AgentService | py/services/agent/agent_service.py |
| SkillRegistry | py/services/agent/skill_registry.py |
| SkillDefinition | py/services/agent/skill_definition.py |
| Skills directory | py/services/agent/skills/ |
| Route handlers | py/routes/handlers/agent_handlers.py |
| Frontend manager | static/js/managers/AgentManager.js |
| Settings UI | templates/components/modals/settings_modal.html |
| Context menu | templates/components/context_menu.html |