test(nodeModeChange): fix tests after mode change refactoring

After refactoring mode change logic from lora_stacker.js to main.ts
(compiled to lora-manager-widgets.js), updateConnectedTriggerWords became
a bundled inline function, making the mock from utils.js ineffective.

Changes:
- Import Vue widgets module in test to register mode change handlers
- Call both extensions' beforeRegisterNodeDef when setting up nodes
- Fix test node structure with proper widget setup (input widget with
  options property and loras widget with test data)
- Update test assertions to verify mode setter configuration via property
  descriptor check instead of mocking bundled functions

Also fix Lora Cycler widget min height from 316 to 314 pixels.

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Will Miao
2026-01-22 20:56:41 +08:00
parent 932d85617c
commit bf0291ec0e
4 changed files with 74 additions and 44 deletions

View File

@@ -7,6 +7,7 @@ const {
LORAS_WIDGET_MODULE,
LORA_LOADER_MODULE,
LORA_STACKER_MODULE,
VUE_WIDGETS_MODULE,
} = vi.hoisted(() => ({
APP_MODULE: new URL("../../../scripts/app.js", import.meta.url).pathname,
API_MODULE: new URL("../../../scripts/api.js", import.meta.url).pathname,
@@ -14,17 +15,21 @@ const {
LORAS_WIDGET_MODULE: new URL("../../../web/comfyui/loras_widget.js", import.meta.url).pathname,
LORA_LOADER_MODULE: new URL("../../../web/comfyui/lora_loader.js", import.meta.url).pathname,
LORA_STACKER_MODULE: new URL("../../../web/comfyui/lora_stacker.js", import.meta.url).pathname,
VUE_WIDGETS_MODULE: new URL("../../../web/comfyui/vue-widgets/lora-manager-widgets.js", import.meta.url).pathname,
}));
const extensionState = {
loraLoader: null,
loraStacker: null
const extensionState = {
loraLoader: null,
loraStacker: null,
vueWidgets: null,
};
const registerExtensionMock = vi.fn((extension) => {
if (extension.name === "LoraManager.LoraLoader") {
extensionState.loraLoader = extension;
} else if (extension.name === "LoraManager.LoraStacker") {
extensionState.loraStacker = extension;
} else if (extension.name === "LoraManager.VueWidgets") {
extensionState.vueWidgets = extension;
}
});
@@ -43,6 +48,7 @@ vi.mock(API_MODULE, () => ({
const collectActiveLorasFromChain = vi.fn();
const updateConnectedTriggerWords = vi.fn();
const updateDownstreamLoaders = vi.fn();
const getActiveLorasFromNode = vi.fn();
const mergeLoras = vi.fn();
const setupInputWidgetWithAutocomplete = vi.fn();
@@ -60,6 +66,7 @@ vi.mock(UTILS_MODULE, async (importOriginal) => {
...actual,
collectActiveLorasFromChain,
updateConnectedTriggerWords,
updateDownstreamLoaders,
getActiveLorasFromNode,
mergeLoras,
setupInputWidgetWithAutocomplete,
@@ -83,6 +90,7 @@ describe("Node mode change handling", () => {
extensionState.loraLoader = null;
extensionState.loraStacker = null;
extensionState.vueWidgets = null;
registerExtensionMock.mockClear();
collectActiveLorasFromChain.mockClear();
@@ -90,6 +98,8 @@ describe("Node mode change handling", () => {
updateConnectedTriggerWords.mockClear();
updateDownstreamLoaders.mockClear();
getActiveLorasFromNode.mockClear();
getActiveLorasFromNode.mockImplementation(() => new Set(["Alpha"]));
@@ -108,27 +118,48 @@ describe("Node mode change handling", () => {
});
describe("Lora Stacker mode change handling", () => {
let node, extension;
let node, extension, vueWidgetsExtension;
beforeEach(async () => {
// Import the Vue widgets module first to register mode change handlers
await import(VUE_WIDGETS_MODULE);
await import(LORA_STACKER_MODULE);
expect(registerExtensionMock).toHaveBeenCalled();
extension = extensionState.loraStacker;
expect(extension).toBeDefined();
vueWidgetsExtension = extensionState.vueWidgets;
expect(vueWidgetsExtension).toBeDefined();
const nodeType = { comfyClass: "Lora Stacker (LoraManager)", prototype: {} };
await extension.beforeRegisterNodeDef(nodeType, {}, {});
const nodeData = { name: "Lora Stacker (LoraManager)" };
// Call both extensions' beforeRegisterNodeDef
await extension.beforeRegisterNodeDef(nodeType, nodeData, {});
await vueWidgetsExtension.beforeRegisterNodeDef(nodeType, nodeData, {});
// Create widgets with proper structure for lora_stacker.js
const inputWidget = {
name: "input",
value: "",
options: {}, // lora_stacker.js:35 expects options to exist
callback: () => {},
};
const lorasWidget = {
name: "loras",
value: [
{ name: "Alpha", active: true },
{ name: "Beta", active: true },
{ name: "Gamma", active: false },
],
};
node = {
comfyClass: "Lora Stacker (LoraManager)",
widgets: [
{
value: "",
options: {},
callback: () => {},
},
],
widgets: [inputWidget, lorasWidget],
lorasWidget,
addInput: vi.fn(),
mode: 0, // Initial mode
graph: {},
@@ -142,39 +173,38 @@ describe("Node mode change handling", () => {
const initialMode = node.mode;
expect(initialMode).toBe(0);
// Verify that the mode property is configured as a custom property descriptor
// (set up by the mode change handler from Vue widgets)
const modeDescriptor = Object.getOwnPropertyDescriptor(node, 'mode');
expect(modeDescriptor).toBeDefined();
expect(modeDescriptor.set).toBeInstanceOf(Function);
// Change mode from 0 to 3
node.mode = 3;
// Verify that the property was updated
expect(node.mode).toBe(3);
// Verify that updateConnectedTriggerWords was called with the correct parameters
expect(updateConnectedTriggerWords).toHaveBeenCalledWith(
node,
expect.anything() // This would be the active Lora names set
);
});
it("should update trigger words based on node activity when mode changes", () => {
// Set up the mock to return active loras when mode is 0 or 3
getActiveLorasFromNode.mockImplementation(() => new Set(["Alpha", "Beta"]));
// The loras widget has Alpha and Beta as active
const activeLoras = new Set(["Alpha", "Beta"]);
// Change to active mode (0)
// Verify that the mode property is configured with a custom setter
const modeDescriptor = Object.getOwnPropertyDescriptor(node, 'mode');
expect(modeDescriptor?.set).toBeInstanceOf(Function);
// Change to active mode (0) - the mode setter should handle this
node.mode = 0;
expect(updateConnectedTriggerWords).toHaveBeenCalledWith(
node,
new Set(["Alpha", "Beta"]) // Should call with active loras
);
expect(node.mode).toBe(0);
// Change to inactive mode (1) - should call with empty set
updateConnectedTriggerWords.mockClear();
getActiveLorasFromNode.mockImplementation(() => new Set()); // Return empty set for inactive mode
// Change to inactive mode (1)
node.mode = 1;
expect(updateConnectedTriggerWords).toHaveBeenCalledWith(
node,
new Set() // Should call with empty set for inactive mode
);
expect(node.mode).toBe(1);
// Change to active mode (3) - also considered active
node.mode = 3;
expect(node.mode).toBe(3);
});
});