alphard/ComfyUI-Lora-Manager
1
0
Fork 0
mirror of https://github.com/willmiao/ComfyUI-Lora-Manager.git synced 2026-10-10 19:42:13 -03:00
Code Issues Packages Projects Releases Wiki Activity

fix(sidecars): use button-triggered wording in the migration dialog

Browse Source 
The "Migrate Sidecars Now" button reused the mode-change confirmation
copy, which told the user they could migrate later with the very button
they had just clicked. Add manual variants of the confirm messages
(confirmToCentralizedManual / confirmToAlongsideManual) that drop the
mode-change preamble and the circular backreference, and translate them
for all 9 locales.
This commit is contained in:
Will Miao
2026-10-10 18:58:56 +08:00
parent 5796a0e2e9
commit a8941f453f
12 changed files with 68 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/frontend/managers/settingsManager.sidecarStorage.test.js
+38
View File
@@ -359,6 +359,44 @@ describe('SettingsManager sidecar storage', () => {
body: JSON.stringify({ direction: 'to_centralized', force: true }),
}));
});
// The button opens this dialog directly, so the message must not
// describe a mode change or point back at the button itself.
it('uses the button-triggered wording without the mode-change backreference', async () => {
const manager = createManager();
appendSidecarControls();
const modal = appendMigrationModal();
state.global.settings = { sidecar_storage_mode: 'centralized' };
mockFetchOk();
const confirmPromise = manager.confirmAndMigrateSidecars();
await vi.waitFor(() => expect(modal.classList.contains('show')).toBe(true));
const message = modal.querySelector('[data-role="message"]').textContent;
expect(message).toBe('Move existing .metadata.json sidecars and preview images into the centralized storage directory now?');
expect(message).not.toContain('later');
expect(message).not.toContain('Migrate Sidecars Now');
modal.querySelector('[data-action="confirm-sidecar-migration"]').click();
await confirmPromise;
});
it('uses the button-triggered wording when migrating back alongside', async () => {
const manager = createManager();
appendSidecarControls();
const modal = appendMigrationModal();
state.global.settings = { sidecar_storage_mode: 'alongside' };
mockFetchOk();
const confirmPromise = manager.confirmAndMigrateSidecars();
await vi.waitFor(() => expect(modal.classList.contains('show')).toBe(true));
const message = modal.querySelector('[data-role="message"]').textContent;
expect(message).toBe('Move existing .metadata.json sidecars and preview images back next to their model files now?');
modal.querySelector('[data-action="confirm-sidecar-migration"]').click();
await confirmPromise;
});
});
describe('migrateSidecars', () => {