refactor(delete): make undo unconditional, remove undo toggle and button delay

- Remove delete_undo_enabled setting (backend default, frontend state,
  settings modal UI, 10 locales); staged deletes with 30s undo are now
  the only delete path and stale settings keys are silently ignored
- Remove the 1500ms delete-button arm delay (armDeleteButton) from all
  delete modals; misclicks are recoverable via the undo toast
- Delete modal always shows the recoverable warning
- Log the first staged file path in staging log lines for easier support

tests/frontend/components/contextMenu.interactions.test.js

@@ -123,7 +123,6 @@ vi.mock('../../../static/js/state/index.js', () => ({
 vi.mock('../../../static/js/utils/modalUtils.js', () => ({
   showExcludeModal: vi.fn(),
   showDeleteModal: vi.fn(),
-  armDeleteButton: vi.fn(),
 }));
 
 vi.mock('../../../static/js/managers/MoveManager.js', () => ({

tests/frontend/components/duplicatesManager.test.js

@@ -27,16 +27,7 @@ vi.mock('../../../static/js/components/RecipeCard.js', () => ({
   },
 }));
 
-vi.mock('../../../static/js/utils/modalUtils.js', () => ({
-  armDeleteButton: (modalElement) => {
-    if (!modalElement) return null;
-    const buttons = modalElement.querySelectorAll('.delete-btn');
-    buttons.forEach((button) => { button.disabled = true; });
-    return setTimeout(() => {
-      buttons.forEach((button) => { button.disabled = false; });
-    }, 1500);
-  },
-}));
+vi.mock('../../../static/js/utils/modalUtils.js', () => ({}));
 
 vi.mock('../../../static/js/utils/infiniteScroll.js', () => ({
   recreateVirtualScroll: recreateVirtualScrollMock,
@@ -340,41 +331,3 @@ describe('DuplicatesManager confirmDeleteDuplicates undo flows', () => {
     );
   });
 });
-
-describe('DuplicatesManager deleteSelectedDuplicates delay-activate', () => {
-  beforeEach(() => {
-    vi.useFakeTimers();
-    setCurrentPageType('recipes');
-    setupDom();
-    document.body.insertAdjacentHTML('beforeend', `
-      <div id="duplicateDeleteModal" class="modal delete-modal">
-        <div class="delete-model-info"><p><span id="duplicateDeleteCount">0</span></p></div>
-        <button class="cancel-btn">Cancel</button>
-        <button class="delete-btn">Delete</button>
-      </div>
-    `);
-    globalThis.modalManager = { showModal: vi.fn(), closeModal: vi.fn() };
-  });
-
-  afterEach(() => {
-    vi.useRealTimers();
-    delete globalThis.modalManager;
-  });
-
-  it('opens with the delete button disabled and enables it after 1500ms', async () => {
-    const manager = new DuplicatesManager({});
-    manager.selectedForDeletion.add('r1');
-
-    await manager.deleteSelectedDuplicates();
-
-    expect(globalThis.modalManager.showModal).toHaveBeenCalledWith('duplicateDeleteModal');
-    const deleteBtn = document.querySelector('#duplicateDeleteModal .delete-btn');
-    expect(deleteBtn.disabled).toBe(true);
-
-    deleteBtn.click();
-    expect(deleteBtn.disabled).toBe(true);
-
-    vi.advanceTimersByTime(1500);
-    expect(deleteBtn.disabled).toBe(false);
-  });
-});

tests/frontend/components/modelDuplicatesManager.test.js

@@ -18,16 +18,7 @@ vi.mock('../../../static/js/api/modelApiFactory.js', () => ({
   resetAndReload: resetAndReloadMock,
 }));
 
-vi.mock('../../../static/js/utils/modalUtils.js', () => ({
-  armDeleteButton: (modalElement) => {
-    if (!modalElement) return null;
-    const buttons = modalElement.querySelectorAll('.delete-btn');
-    buttons.forEach((button) => { button.disabled = true; });
-    return setTimeout(() => {
-      buttons.forEach((button) => { button.disabled = false; });
-    }, 1500);
-  },
-}));
+vi.mock('../../../static/js/utils/modalUtils.js', () => ({}));
 
 const { ModelDuplicatesManager } = await import('../../../static/js/components/ModelDuplicatesManager.js');
 const { state } = await import('../../../static/js/state/index.js');
@@ -365,36 +356,3 @@ describe('ModelDuplicatesManager confirmDeleteDuplicates undo flows', () => {
     );
   });
 });
-
-describe('ModelDuplicatesManager deleteSelectedDuplicates delay-activate', () => {
-  beforeEach(() => {
-    vi.useFakeTimers();
-    globalThis.modalManager = { showModal: vi.fn(), closeModal: vi.fn() };
-  });
-
-  afterEach(() => {
-    vi.useRealTimers();
-    delete globalThis.modalManager;
-  });
-
-  it('opens with the delete button disabled and enables it after 1500ms', async () => {
-    const manager = await createManager();
-    document.body.insertAdjacentHTML('beforeend', `
-      <div id="modelDuplicateDeleteModal" class="modal delete-modal">
-        <div class="delete-model-info"><p><span id="modelDuplicateDeleteCount">0</span></p></div>
-        <button class="cancel-btn">Cancel</button>
-        <button class="delete-btn">Delete</button>
-      </div>
-    `);
-    manager.selectedForDeletion.add(carPath);
-
-    await manager.deleteSelectedDuplicates();
-
-    expect(globalThis.modalManager.showModal).toHaveBeenCalledWith('modelDuplicateDeleteModal');
-    const deleteBtn = document.querySelector('#modelDuplicateDeleteModal .delete-btn');
-    expect(deleteBtn.disabled).toBe(true);
-
-    vi.advanceTimersByTime(1500);
-    expect(deleteBtn.disabled).toBe(false);
-  });
-});

tests/frontend/components/recipeCard.deleteFriction.test.js

@@ -1,160 +0,0 @@
-import { describe, it, beforeEach, afterEach, expect, vi } from 'vitest';
-
-const {
-  RECIPE_CARD_MODULE,
-  UI_HELPERS_MODULE,
-  RECIPE_API_MODULE,
-  MODEL_CARD_MODULE,
-  MODAL_MANAGER_MODULE,
-  BULK_MANAGER_MODULE,
-  I18N_MODULE,
-  UNDO_HELPERS_MODULE,
-  API_FACTORY_MODULE,
-  STATE_MODULE,
-} = vi.hoisted(() => ({
-  RECIPE_CARD_MODULE: new URL('../../../static/js/components/RecipeCard.js', import.meta.url).pathname,
-  UI_HELPERS_MODULE: new URL('../../../static/js/utils/uiHelpers.js', import.meta.url).pathname,
-  RECIPE_API_MODULE: new URL('../../../static/js/api/recipeApi.js', import.meta.url).pathname,
-  MODEL_CARD_MODULE: new URL('../../../static/js/components/shared/ModelCard.js', import.meta.url).pathname,
-  MODAL_MANAGER_MODULE: new URL('../../../static/js/managers/ModalManager.js', import.meta.url).pathname,
-  BULK_MANAGER_MODULE: new URL('../../../static/js/managers/BulkManager.js', import.meta.url).pathname,
-  I18N_MODULE: new URL('../../../static/js/utils/i18nHelpers.js', import.meta.url).pathname,
-  UNDO_HELPERS_MODULE: new URL('../../../static/js/utils/undoHelpers.js', import.meta.url).pathname,
-  API_FACTORY_MODULE: new URL('../../../static/js/api/modelApiFactory.js', import.meta.url).pathname,
-  STATE_MODULE: new URL('../../../static/js/state/index.js', import.meta.url).pathname,
-}));
-
-const showModalMock = vi.fn();
-const closeModalMock = vi.fn();
-
-vi.mock(UI_HELPERS_MODULE, () => ({
-  showToast: vi.fn(),
-  showActionToast: vi.fn(),
-  copyToClipboard: vi.fn(),
-  sendLoraToWorkflow: vi.fn(),
-}));
-
-vi.mock(RECIPE_API_MODULE, () => ({
-  updateRecipeMetadata: vi.fn(),
-}));
-
-vi.mock(MODEL_CARD_MODULE, () => ({
-  configureModelCardVideo: vi.fn(),
-}));
-
-vi.mock(MODAL_MANAGER_MODULE, () => ({
-  modalManager: {
-    showModal: showModalMock,
-    closeModal: closeModalMock,
-  },
-}));
-
-vi.mock(BULK_MANAGER_MODULE, () => ({
-  bulkManager: {},
-}));
-
-vi.mock(I18N_MODULE, () => ({
-  translate: vi.fn((key) => key),
-}));
-
-vi.mock(UNDO_HELPERS_MODULE, () => ({
-  handleUndoDelete: vi.fn(),
-}));
-
-// modalUtils.js is intentionally NOT mocked — its real armDeleteButton drives
-// the delay-activate behavior under test. Its own imports are mocked below.
-vi.mock(API_FACTORY_MODULE, () => ({
-  getModelApiClient: vi.fn(),
-  resetAndReload: vi.fn(),
-}));
-
-describe('RecipeCard delete confirmation delay-activate', () => {
-  let capturedOnClose;
-
-  beforeEach(async () => {
-    vi.useFakeTimers();
-    showModalMock.mockReset();
-    closeModalMock.mockReset();
-    capturedOnClose = null;
-    document.body.innerHTML = '<div id="deleteModal" class="modal delete-modal"></div>';
-    showModalMock.mockImplementation((id, content, onClose) => {
-      if (content) {
-        document.getElementById(id).innerHTML = content;
-      }
-      capturedOnClose = onClose;
-    });
-    global.fetch = vi.fn().mockResolvedValue({
-      ok: true,
-      json: async () => ({ success: true }),
-    });
-    window.recipeManager = { loadRecipes: vi.fn() };
-    const { state } = await import(STATE_MODULE);
-    state.virtualScroller = { removeItemByFilePath: vi.fn() };
-  });
-
-  afterEach(() => {
-    vi.useRealTimers();
-    delete global.fetch;
-    delete window.recipeManager;
-    document.body.innerHTML = '';
-  });
-
-  async function createCard() {
-    const { RecipeCard } = await import(RECIPE_CARD_MODULE);
-    const card = Object.create(RecipeCard.prototype);
-    card.recipe = { id: 'recipe-1', title: 'My Recipe', file_path: '/recipes/r1.json', file_url: '/preview.png' };
-    return card;
-  }
-
-  it('opens with a disabled delete button that ignores clicks until 1500ms elapse', async () => {
-    const card = await createCard();
-    card.showDeleteConfirmation();
-
-    const deleteBtn = document.querySelector('#deleteModal .delete-btn');
-    expect(deleteBtn.disabled).toBe(true);
-
-    deleteBtn.click();
-    expect(global.fetch).not.toHaveBeenCalled();
-
-    vi.advanceTimersByTime(1500);
-    expect(deleteBtn.disabled).toBe(false);
-
-    deleteBtn.click();
-    expect(global.fetch).toHaveBeenCalledWith(
-      '/api/lm/recipe/recipe-1',
-      expect.objectContaining({ method: 'DELETE' })
-    );
-  });
-
-  it('clears the pending arm timer when the modal closes during the countdown', async () => {
-    const card = await createCard();
-    card.showDeleteConfirmation();
-
-    const deleteBtn = document.querySelector('#deleteModal .delete-btn');
-    expect(deleteBtn.disabled).toBe(true);
-
-    vi.advanceTimersByTime(700);
-    capturedOnClose();
-
-    expect(deleteBtn.disabled).toBe(false);
-    expect(vi.getTimerCount()).toBe(0);
-  });
-
-  it('re-arms a full 1500ms countdown when the modal is reopened', async () => {
-    const card = await createCard();
-    card.showDeleteConfirmation();
-
-    vi.advanceTimersByTime(1400);
-    capturedOnClose();
-
-    card.showDeleteConfirmation();
-    const deleteBtn = document.querySelector('#deleteModal .delete-btn');
-    expect(deleteBtn.disabled).toBe(true);
-
-    vi.advanceTimersByTime(1499);
-    expect(deleteBtn.disabled).toBe(true);
-
-    vi.advanceTimersByTime(1);
-    expect(deleteBtn.disabled).toBe(false);
-  });
-});

tests/frontend/managers/BulkManager.bulkDelete.test.js

@@ -332,41 +332,3 @@ describe('BulkManager.confirmBulkDelete undo flows', () => {
     expect(resetAndReloadMock).not.toHaveBeenCalled();
   });
 });
-
-describe('BulkManager.showBulkDeleteModal delay-activate', () => {
-  beforeEach(() => {
-    vi.useFakeTimers();
-    stateStub.currentPageType = 'loras';
-    stateStub.selectedModels.clear();
-    stateStub.selectedModels.add('/models/a.safetensors');
-    document.body.innerHTML = `
-      <div id="bulkDeleteModal" class="modal delete-modal">
-        <h2></h2>
-        <p class="delete-message"></p>
-        <div class="delete-model-info"><p></p></div>
-        <button class="cancel-btn">Cancel</button>
-        <button class="delete-btn">Delete</button>
-      </div>
-    `;
-  });
-
-  afterEach(() => {
-    vi.useRealTimers();
-    document.body.innerHTML = '';
-  });
-
-  it('opens with the delete button disabled and enables it after 1500ms', async () => {
-    const { BulkManager } = await import('../../../static/js/managers/BulkManager.js');
-    const bulk = new BulkManager();
-    bulk.showBulkDeleteModal();
-
-    const deleteBtn = document.querySelector('#bulkDeleteModal .delete-btn');
-    expect(deleteBtn.disabled).toBe(true);
-
-    deleteBtn.click();
-    expect(bulkDeleteModelsMock).not.toHaveBeenCalled();
-
-    vi.advanceTimersByTime(1500);
-    expect(deleteBtn.disabled).toBe(false);
-  });
-});

tests/frontend/managers/settingsManager.deleteUndo.test.js

@@ -1,228 +0,0 @@
-import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
-import { readFileSync } from 'node:fs';
-import { fileURLToPath } from 'node:url';
-import { dirname, resolve } from 'node:path';
-
-vi.mock('../../../static/js/managers/ModalManager.js', () => ({
-    modalManager: {
-        closeModal: vi.fn(),
-    },
-}));
-
-vi.mock('../../../static/js/utils/uiHelpers.js', () => ({
-    showToast: vi.fn(),
-}));
-
-vi.mock('../../../static/js/state/index.js', () => {
-    const settings = {};
-    return {
-        state: {
-            global: {
-                settings,
-            },
-            loadingManager: {
-                showSimpleLoading: vi.fn(),
-                hide: vi.fn(),
-            },
-        },
-        createDefaultSettings: () => ({
-            language: 'en',
-            delete_undo_enabled: true,
-        }),
-    };
-});
-
-vi.mock('../../../static/js/api/modelApiFactory.js', () => ({
-    resetAndReload: vi.fn(),
-}));
-
-vi.mock('../../../static/js/utils/constants.js', () => ({
-    DOWNLOAD_PATH_TEMPLATES: {},
-    DEFAULT_PATH_TEMPLATES: {},
-    MAPPABLE_BASE_MODELS: [],
-    PATH_TEMPLATE_PLACEHOLDERS: {},
-    DEFAULT_PRIORITY_TAG_CONFIG: {
-        lora: 'character, style',
-        checkpoint: 'base, guide',
-        embedding: 'hint',
-    },
-    getMappableBaseModelsDynamic: () => [],
-}));
-
-vi.mock('../../../static/js/utils/i18nHelpers.js', () => ({
-    translate: (_key, _params, fallback) => fallback ?? '',
-}));
-
-vi.mock('../../../static/js/i18n/index.js', () => ({
-    i18n: {
-        getCurrentLocale: () => 'en',
-        setLanguage: vi.fn().mockResolvedValue(),
-    },
-}));
-
-vi.mock('../../../static/js/components/shared/ModelCard.js', () => ({
-    configureModelCardVideo: vi.fn(),
-}));
-
-import { SettingsManager } from '../../../static/js/managers/SettingsManager.js';
-import { showToast } from '../../../static/js/utils/uiHelpers.js';
-import { state } from '../../../static/js/state/index.js';
-
-const repoRoot = resolve(dirname(fileURLToPath(import.meta.url)), '../../..');
-
-const createManager = () => {
-    state.global.settings = {};
-    const initSettingsSpy = vi
-        .spyOn(SettingsManager.prototype, 'initializeSettings')
-        .mockResolvedValue();
-    const initializeSpy = vi
-        .spyOn(SettingsManager.prototype, 'initialize')
-        .mockImplementation(() => {});
-
-    const manager = new SettingsManager();
-
-    initSettingsSpy.mockRestore();
-    initializeSpy.mockRestore();
-
-    return manager;
-};
-
-const appendDeleteUndoCheckbox = () => {
-    const checkbox = document.createElement('input');
-    checkbox.type = 'checkbox';
-    checkbox.id = 'deleteUndoEnabled';
-    document.body.appendChild(checkbox);
-    return checkbox;
-};
-
-const stubLoadSettingsSubloaders = (manager) => {
-    vi.spyOn(manager, 'loadMetadataArchiveSettings').mockResolvedValue();
-    vi.spyOn(manager, 'loadBackupSettings').mockResolvedValue();
-    vi.spyOn(manager, 'loadLibraries').mockResolvedValue();
-    vi.spyOn(manager, 'loadLoraRoots').mockResolvedValue();
-    vi.spyOn(manager, 'loadCheckpointRoots').mockResolvedValue();
-    vi.spyOn(manager, 'loadUnetRoots').mockResolvedValue();
-    vi.spyOn(manager, 'loadEmbeddingRoots').mockResolvedValue();
-};
-
-beforeEach(() => {
-    document.body.innerHTML = '';
-    vi.clearAllMocks();
-});
-
-afterEach(() => {
-    delete global.fetch;
-});
-
-describe('SettingsManager delete undo toggle', () => {
-    it('renders the checkbox markup with a resolvable i18n label', () => {
-        const template = readFileSync(
-            resolve(repoRoot, 'templates/components/modals/settings_modal.html'),
-            'utf8',
-        );
-        const locales = JSON.parse(
-            readFileSync(resolve(repoRoot, 'locales/en.json'), 'utf8'),
-        );
-
-        // The label must resolve to real text, not fall back to the raw key.
-        expect(locales.settings.deleteUndoEnabled).toBe(
-            'Keep deleted items recoverable for 30 seconds (undo)',
-        );
-        expect(template).toContain('id="deleteUndoEnabled"');
-        expect(template).toContain("t('settings.deleteUndoEnabled')");
-        expect(template).toContain(
-            "settingsManager.saveToggleSetting('deleteUndoEnabled', 'delete_undo_enabled')",
-        );
-    });
-
-    it('restores the checkbox as unchecked when the saved setting is false', async () => {
-        const manager = createManager();
-        const checkbox = appendDeleteUndoCheckbox();
-        checkbox.checked = true;
-
-        stubLoadSettingsSubloaders(manager);
-        global.fetch = vi.fn().mockResolvedValue({
-            ok: true,
-            json: async () => ({ success: true }),
-        });
-
-        state.global.settings = { delete_undo_enabled: false };
-
-        await manager.loadSettingsToUI();
-
-        expect(checkbox.checked).toBe(false);
-    });
-
-    it('restores the checkbox as checked when the saved setting is true or absent', async () => {
-        const manager = createManager();
-        const checkbox = appendDeleteUndoCheckbox();
-
-        stubLoadSettingsSubloaders(manager);
-        global.fetch = vi.fn().mockResolvedValue({
-            ok: true,
-            json: async () => ({ success: true }),
-        });
-
-        state.global.settings = { delete_undo_enabled: true };
-        await manager.loadSettingsToUI();
-        expect(checkbox.checked).toBe(true);
-
-        checkbox.checked = false;
-        state.global.settings = {};
-        await manager.loadSettingsToUI();
-        expect(checkbox.checked).toBe(true);
-    });
-
-    it('saves delete_undo_enabled to the backend when the checkbox is toggled', async () => {
-        const manager = createManager();
-        const checkbox = appendDeleteUndoCheckbox();
-        checkbox.checked = false;
-
-        state.global.settings = { delete_undo_enabled: true };
-
-        global.fetch = vi.fn().mockResolvedValue({
-            ok: true,
-            json: async () => ({ success: true }),
-        });
-
-        await manager.saveToggleSetting('deleteUndoEnabled', 'delete_undo_enabled');
-
-        expect(state.global.settings.delete_undo_enabled).toBe(false);
-        expect(global.fetch).toHaveBeenCalledWith('/api/lm/settings', {
-            method: 'POST',
-            headers: {
-                'Content-Type': 'application/json',
-            },
-            body: JSON.stringify({ delete_undo_enabled: false }),
-        });
-        expect(showToast).toHaveBeenCalledWith(
-            'toast.settings.settingsUpdated',
-            { setting: 'delete undo enabled' },
-            'success',
-        );
-    });
-
-    it('saves delete_undo_enabled as true when re-enabled', async () => {
-        const manager = createManager();
-        const checkbox = appendDeleteUndoCheckbox();
-        checkbox.checked = true;
-
-        state.global.settings = { delete_undo_enabled: false };
-
-        global.fetch = vi.fn().mockResolvedValue({
-            ok: true,
-            json: async () => ({ success: true }),
-        });
-
-        await manager.saveToggleSetting('deleteUndoEnabled', 'delete_undo_enabled');
-
-        expect(state.global.settings.delete_undo_enabled).toBe(true);
-        expect(global.fetch).toHaveBeenCalledWith('/api/lm/settings', {
-            method: 'POST',
-            headers: {
-                'Content-Type': 'application/json',
-            },
-            body: JSON.stringify({ delete_undo_enabled: true }),
-        });
-    });
-});

tests/frontend/pages/checkpointsPage.test.js

@@ -34,7 +34,6 @@ vi.mock('../../../static/js/utils/modalUtils.js', () => ({
   closeDeleteModal: closeDeleteModalMock,
   confirmExclude: confirmExcludeMock,
   closeExcludeModal: closeExcludeModalMock,
-  armDeleteButton: vi.fn(),
 }));
 
 vi.mock('../../../static/js/components/ModelDuplicatesManager.js', () => ({

tests/frontend/pages/embeddingsPage.test.js

@@ -26,7 +26,6 @@ vi.mock('../../../static/js/utils/modalUtils.js', () => ({
   closeDeleteModal: closeDeleteModalMock,
   confirmExclude: confirmExcludeMock,
   closeExcludeModal: closeExcludeModalMock,
-  armDeleteButton: vi.fn(),
 }));
 
 vi.mock('../../../static/js/api/apiConfig.js', () => ({

tests/frontend/pages/lorasPage.test.js

@@ -36,7 +36,6 @@ vi.mock('../../../static/js/utils/modalUtils.js', () => ({
   closeDeleteModal: closeDeleteModalMock,
   confirmExclude: confirmExcludeMock,
   closeExcludeModal: closeExcludeModalMock,
-  armDeleteButton: vi.fn(),
 }));
 
 vi.mock('../../../static/js/components/ModelDuplicatesManager.js', () => ({

tests/frontend/utils/i18nHelpers.test.js

@@ -66,9 +66,6 @@ describe('translate() with real en.json locale', () => {
     it('resolves delete-model modal keys with interpolation', () => {
         installWindowI18n();
 
-        expect(translate('modals.deleteModel.permanentWarning')).toBe(
-            'This will permanently delete the file from disk.',
-        );
         expect(translate('modals.deleteModel.recoverableWarning')).toBe(
             'This will permanently delete the file after 30 seconds unless you undo.',
         );
@@ -77,14 +74,6 @@ describe('translate() with real en.json locale', () => {
         );
     });
 
-    it('resolves the delete-undo settings label', () => {
-        installWindowI18n();
-
-        expect(translate('settings.deleteUndoEnabled')).toBe(
-            'Keep deleted items recoverable for 30 seconds (undo)',
-        );
-    });
-
     it('returns the raw key when no translation exists (fallback contract)', () => {
         installWindowI18n();
         const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {});

tests/frontend/utils/modalUtils.test.js

@@ -1,4 +1,4 @@
-import { describe, it, beforeEach, afterEach, expect, vi } from 'vitest';
+import { describe, it, beforeEach, expect, vi } from 'vitest';
 
 const {
   MODAL_UTILS_MODULE,
@@ -7,7 +7,6 @@ const {
   UI_HELPERS_MODULE,
   I18N_MODULE,
   UNDO_HELPERS_MODULE,
-  STATE_MODULE,
 } = vi.hoisted(() => ({
   MODAL_UTILS_MODULE: new URL('../../../static/js/utils/modalUtils.js', import.meta.url).pathname,
   MODAL_MANAGER_MODULE: new URL('../../../static/js/managers/ModalManager.js', import.meta.url).pathname,
@@ -15,7 +14,6 @@ const {
   UI_HELPERS_MODULE: new URL('../../../static/js/utils/uiHelpers.js', import.meta.url).pathname,
   I18N_MODULE: new URL('../../../static/js/utils/i18nHelpers.js', import.meta.url).pathname,
   UNDO_HELPERS_MODULE: new URL('../../../static/js/utils/undoHelpers.js', import.meta.url).pathname,
-  STATE_MODULE: new URL('../../../static/js/state/index.js', import.meta.url).pathname,
 }));
 
 const deleteModelMock = vi.fn();
@@ -136,75 +134,6 @@ describe('modalUtils confirmDelete undo flow', () => {
   });
 });
 
-describe('modalUtils armDeleteButton delay-activate', () => {
-  beforeEach(() => {
-    vi.useFakeTimers();
-    deleteModelMock.mockReset();
-    showModalMock.mockReset();
-    closeModalMock.mockReset();
-    document.body.innerHTML = `
-      <div class="model-card" data-filepath="/models/foo.safetensors" data-name="Foo Model"></div>
-      <div id="deleteModal">
-        <div class="delete-model-info"></div>
-        <button class="cancel-btn">Cancel</button>
-        <button class="delete-btn">Delete</button>
-      </div>
-    `;
-  });
-
-  afterEach(() => {
-    vi.useRealTimers();
-  });
-
-  it('opens with the delete button disabled and enables it after exactly 1500ms', async () => {
-    const { showDeleteModal } = await import(MODAL_UTILS_MODULE);
-
-    showDeleteModal('/models/foo.safetensors');
-
-    const deleteBtn = document.querySelector('#deleteModal .delete-btn');
-    expect(deleteBtn.disabled).toBe(true);
-
-    vi.advanceTimersByTime(1499);
-    expect(deleteBtn.disabled).toBe(true);
-
-    vi.advanceTimersByTime(1);
-    expect(deleteBtn.disabled).toBe(false);
-  });
-
-  it('clicking the disabled delete button fires nothing', async () => {
-    const { showDeleteModal } = await import(MODAL_UTILS_MODULE);
-
-    showDeleteModal('/models/foo.safetensors');
-
-    const deleteBtn = document.querySelector('#deleteModal .delete-btn');
-    deleteBtn.click();
-
-    expect(deleteBtn.disabled).toBe(true);
-    expect(deleteModelMock).not.toHaveBeenCalled();
-  });
-
-  it('closing during the countdown clears the timer and reopening re-arms a full 1500ms', async () => {
-    const { showDeleteModal, closeDeleteModal } = await import(MODAL_UTILS_MODULE);
-
-    showDeleteModal('/models/foo.safetensors');
-    const deleteBtn = document.querySelector('#deleteModal .delete-btn');
-
-    vi.advanceTimersByTime(1400);
-    closeDeleteModal();
-    expect(closeModalMock).toHaveBeenCalledWith('deleteModal');
-
-    // Reopen — the stale timer must not enable the button early
-    showDeleteModal('/models/foo.safetensors');
-    expect(deleteBtn.disabled).toBe(true);
-
-    vi.advanceTimersByTime(1499);
-    expect(deleteBtn.disabled).toBe(true);
-
-    vi.advanceTimersByTime(1);
-    expect(deleteBtn.disabled).toBe(false);
-  });
-});
-
 describe('modalUtils showDeleteModal warning copy and size line', () => {
   beforeEach(() => {
     showModalMock.mockReset();
@@ -220,19 +149,11 @@ describe('modalUtils showDeleteModal warning copy and size line', () => {
     `;
   });
 
-  afterEach(async () => {
-    const { state } = await import(STATE_MODULE);
-    state.global.settings.delete_undo_enabled = true;
-  });
-
   function modelInfoHtml() {
     return document.querySelector('#deleteModal .delete-model-info').innerHTML;
   }
 
-  it('shows the recoverable warning when delete_undo_enabled is truthy', async () => {
-    const { state } = await import(STATE_MODULE);
-    state.global.settings.delete_undo_enabled = true;
-
+  it('always shows the recoverable warning', async () => {
     const { showDeleteModal } = await import(MODAL_UTILS_MODULE);
     showDeleteModal('/models/foo.safetensors');
 
@@ -240,27 +161,6 @@ describe('modalUtils showDeleteModal warning copy and size line', () => {
     expect(modelInfoHtml()).not.toContain('modals.deleteModel.permanentWarning');
   });
 
-  it('shows the permanent warning when delete_undo_enabled is falsy', async () => {
-    const { state } = await import(STATE_MODULE);
-    state.global.settings.delete_undo_enabled = false;
-
-    const { showDeleteModal } = await import(MODAL_UTILS_MODULE);
-    showDeleteModal('/models/foo.safetensors');
-
-    expect(modelInfoHtml()).toContain('modals.deleteModel.permanentWarning');
-    expect(modelInfoHtml()).not.toContain('modals.deleteModel.recoverableWarning');
-  });
-
-  it('falls back to the neutral permanent warning when the setting is unavailable', async () => {
-    const { state } = await import(STATE_MODULE);
-    delete state.global.settings.delete_undo_enabled;
-
-    const { showDeleteModal } = await import(MODAL_UTILS_MODULE);
-    showDeleteModal('/models/foo.safetensors');
-
-    expect(modelInfoHtml()).toContain('modals.deleteModel.permanentWarning');
-  });
-
   it('appends a formatted "Frees {size}" line when the card carries a file size', async () => {
     translateMock.mockImplementation((key, params) =>
       params && params.size ? `${key} ${params.size}` : key

tests/services/test_model_lifecycle_service.py

@@ -10,7 +10,6 @@ import pytest
 
 from py.services.model_lifecycle_service import ModelLifecycleService, _require_path_in_library_roots
 from py.services.pending_delete_service import PENDING_DELETE_DIR_NAME, _reset_pending_delete_service
-from py.services.settings_manager import get_settings_manager
 from py.utils.metadata_manager import MetadataManager
 from py.utils.models import LoraMetadata
 
@@ -953,11 +952,11 @@ def _make_delete_service(scanner: Any) -> ModelLifecycleService:
 
 
 @pytest.mark.asyncio
-async def test_delete_model_stages_file_when_undo_enabled(tmp_path: Path):
-    """Undo enabled (the default): artifacts are renamed into a
-    ``.lm-pending-delete/<batch_id>/`` staging dir under the model root, the
-    response carries the batch_id, the cache entry is removed and the cache
-    is persisted (``_persist_calls`` tracked by ``ScannerForDelete``)."""
+async def test_delete_model_stages_file(tmp_path: Path):
+    """Artifacts are renamed into a ``.lm-pending-delete/<batch_id>/`` staging
+    dir under the model root, the response carries the batch_id, the cache
+    entry is removed and the cache is persisted (``_persist_calls`` tracked by
+    ``ScannerForDelete``)."""
     root = tmp_path / "loras"
     root.mkdir()
     model_path = root / "model.safetensors"
@@ -999,41 +998,6 @@ async def test_delete_model_stages_file_when_undo_enabled(tmp_path: Path):
     assert scanner._persist_calls == [True]
 
 
-@pytest.mark.asyncio
-async def test_delete_model_hard_deletes_when_undo_disabled(
-    tmp_path: Path, monkeypatch: pytest.MonkeyPatch
-):
-    """delete_undo_enabled=false: old os.remove behavior, batch_id is None and
-    no staging directory is ever created."""
-    root = tmp_path / "loras"
-    root.mkdir()
-    model_path = root / "model.safetensors"
-    model_path.write_bytes(b"content")
-
-    settings_manager = get_settings_manager()
-    monkeypatch.setattr(
-        settings_manager,
-        "get",
-        lambda key, default=None: False
-        if key == "delete_undo_enabled"
-        else default,
-    )
-
-    scanner = ScannerForDelete(
-        raw_data=[{"file_path": str(model_path)}],
-        roots=[str(root)],
-    )
-    service = _make_delete_service(scanner)
-
-    result = await service.delete_model(str(model_path))
-
-    assert result["success"] is True
-    assert result["batch_id"] is None
-    assert result["deleted_files"]
-    assert not model_path.exists()
-    assert not (root / PENDING_DELETE_DIR_NAME).exists()
-
-
 @pytest.mark.asyncio
 async def test_delete_model_falls_back_when_staging_fails(
     tmp_path: Path, monkeypatch: pytest.MonkeyPatch

tests/services/test_model_scanner.py

@@ -22,7 +22,6 @@ from py.services.pending_delete_service import (
     _reset_pending_delete_service,
 )
 from py.services.persistent_model_cache import PersistentModelCache, DEFAULT_LICENSE_FLAGS
-from py.services.settings_manager import get_settings_manager
 from py.utils.civitai_utils import build_license_flags
 from py.utils.models import BaseModelMetadata
 
@@ -1166,33 +1165,6 @@ async def test_bulk_delete_merge_failure_falls_back_to_batch_ids(
     assert sorted(staged_files) == ["one.txt", "two.txt"]
 
 
-@pytest.mark.asyncio
-async def test_bulk_delete_undo_disabled_hard_deletes(tmp_path: Path):
-    """delete_undo_enabled=false -> old hard delete, no batch, no staging dirs."""
-    root = tmp_path / "loras"
-    root.mkdir()
-    first = root / "one.txt"
-    first.write_text("one", encoding="utf-8")
-    second = root / "two.txt"
-    second.write_text("two", encoding="utf-8")
-    scanner = _make_bulk_scanner(root, [first, second])
-
-    get_settings_manager().settings["delete_undo_enabled"] = False
-
-    result = await scanner.bulk_delete_models([str(first), str(second)])
-
-    assert result["success"] is True
-    assert result["status"] == "success"
-    assert result["total_deleted"] == 2
-    assert result.get("batch_id") is None
-    assert "batch_ids" not in result
-
-    # Old hard-delete behavior: files removed, zero staging dirs created.
-    assert not first.exists()
-    assert not second.exists()
-    assert not (root / PENDING_DELETE_DIR_NAME).exists()
-
-
 @pytest.mark.asyncio
 async def test_bulk_delete_cancelled_after_one_staged_batch_present(
     tmp_path: Path, monkeypatch

tests/services/test_pending_delete_service.py

@@ -31,7 +31,6 @@ from py.services.pending_delete_service import (
 )
 from py.services.model_hash_index import ModelHashIndex
 from py.services.model_scanner import ModelScanner
-from py.services.settings_manager import DEFAULT_SETTINGS, get_settings_manager
 from py.utils import settings_paths
 from py.utils.models import LoraMetadata
 
@@ -771,32 +770,6 @@ async def test_l2_merge_basename_collision_aborts_without_dropping_files(
     assert (sub_b / "model.safetensors").read_bytes() == b"model-data"
 
 
-# ---------------------------------------------------------------------------
-# (m) delete_undo_enabled=false -> stage returns None, nothing created
-# ---------------------------------------------------------------------------
-async def test_m_undo_disabled_returns_none(tmp_path: Path) -> None:
-    root = tmp_path / "loras"
-    root.mkdir()
-    model = root / "model.safetensors"
-    model.write_bytes(b"data")
-
-    get_settings_manager().settings["delete_undo_enabled"] = False
-
-    service = await PendingDeleteService.get_instance()
-    batch_id = await service.stage_model_delete(
-        scanner=ScannerForStage([root]),
-        target_dir=str(root),
-        file_name="model",
-        main_extension=".safetensors",
-        original_file_path=str(model),
-        cached_entry=None,
-    )
-
-    assert batch_id is None
-    assert model.exists()
-    assert not (root / PENDING_DELETE_DIR_NAME).exists()
-
-
 # ---------------------------------------------------------------------------
 # (n) simulated OSError during staging -> rollback, no orphaned batch dir
 # ---------------------------------------------------------------------------
@@ -839,13 +812,6 @@ async def test_n_staging_oserror_rolls_back(tmp_path: Path, monkeypatch) -> None
         assert not any(staging.iterdir())
 
 
-# ---------------------------------------------------------------------------
-# (o) DEFAULT_SETTINGS contains delete_undo_enabled=True
-# ---------------------------------------------------------------------------
-def test_o_default_settings_contains_undo_enabled() -> None:
-    assert DEFAULT_SETTINGS.get("delete_undo_enabled") is True
-
-
 # ---------------------------------------------------------------------------
 # (p) SCANNER EXCLUSION
 # ---------------------------------------------------------------------------

tests/services/test_recipe_persistence.py

@@ -31,7 +31,6 @@ from py.services.recipes.persistence_service import (
     PersistenceResult,
     RecipePersistenceService,
 )
-from py.services.settings_manager import get_settings_manager
 from py.utils import settings_paths
 
 
@@ -223,29 +222,6 @@ async def test_delete_recipe_skips_missing_preview_image(tmp_path: Path) -> None
     assert scanner.removed == ["r2"]
 
 
-# ---------------------------------------------------------------------------
-# (3) undo disabled -> no staging, payload batch_id None, existing behavior
-# ---------------------------------------------------------------------------
-async def test_delete_recipe_undo_disabled_no_staging(tmp_path: Path) -> None:
-    get_settings_manager().settings["delete_undo_enabled"] = False
-
-    scanner = RecipeScannerStub(tmp_path)
-    json_path, image_path, _recipe_data = _write_recipe(tmp_path, "r3")
-    scanner.register_recipe("r3", json_path)
-
-    result = await _make_service().delete_recipe(
-        recipe_scanner=scanner, recipe_id="r3"
-    )
-
-    assert result.payload["batch_id"] is None
-    # No staging leftovers when undo is disabled.
-    assert not _staging_parent().exists()
-    # Existing hard delete behavior unchanged.
-    assert not json_path.exists()
-    assert not image_path.exists()
-    assert scanner.removed == ["r3"]
-
-
 # ---------------------------------------------------------------------------
 # (4) bulk_delete with 2 ids -> single batch_id, one batch dir with both
 #     recipes, re-anchored expires_at in the merged manifest

tests/services/test_settings_manager.py

@@ -1178,8 +1178,3 @@ def test_skip_previously_downloaded_model_versions_coerces_string_input(manager)
 
     assert manager.get_skip_previously_downloaded_model_versions() is True
     assert manager.settings["skip_previously_downloaded_model_versions"] is True
-
-
-def test_delete_undo_enabled_defaults_true(manager):
-    assert settings_manager_module.DEFAULT_SETTINGS.get("delete_undo_enabled") is True
-    assert manager.get("delete_undo_enabled") is True