refactor(model-type): complete phase 5 cleanup by removing deprecated model_type field

- Remove backward compatibility code for `model_type` in `ModelScanner._build_cache_entry()`
- Update `CheckpointScanner` to only handle `sub_type` in `adjust_metadata()` and `adjust_cached_entry()`
- Delete deprecated aliases `resolve_civitai_model_type` and `normalize_civitai_model_type` from `model_query.py`
- Update frontend components (`RecipeModal.js`, `ModelCard.js`, etc.) to use `sub_type` instead of `model_type`
- Update API response format to return only `sub_type`, removing `model_type` from service responses
- Revise technical documentation to mark Phase 5 as completed and remove outdated TODO items

All cleanup tasks for the model type refactoring are now complete, ensuring consistent use of `sub_type` across the codebase.

py/services/lora_service.py

@@ -3,6 +3,7 @@ import logging
 from typing import Dict, List, Optional
 
 from .base_model_service import BaseModelService
+from .model_query import resolve_sub_type
 from ..utils.models import LoraMetadata
 from ..config import config
 
@@ -23,8 +24,9 @@ class LoraService(BaseModelService):
 
     async def format_response(self, lora_data: Dict) -> Dict:
         """Format LoRA data for API response"""
-        # Get sub_type from cache entry (new field) or fallback to model_type (old field)
-        sub_type = lora_data.get("sub_type") or lora_data.get("model_type", "lora")
+        # Resolve sub_type using priority: sub_type > model_type > civitai.model.type > default
+        # Normalize to lowercase for consistent API responses
+        sub_type = resolve_sub_type(lora_data).lower()
         
         return {
             "model_name": lora_data["model_name"],
@@ -46,8 +48,7 @@ class LoraService(BaseModelService):
             "notes": lora_data.get("notes", ""),
             "favorite": lora_data.get("favorite", False),
             "update_available": bool(lora_data.get("update_available", False)),
-            "sub_type": sub_type,  # New canonical field
-            "model_type": sub_type,  # Backward compatibility
+            "sub_type": sub_type,
             "civitai": self.filter_civitai_data(
                 lora_data.get("civitai", {}), minimal=True
             ),