From 5c53968caa0b69f57a2b8214f915dd9536be1149 Mon Sep 17 00:00:00 2001 From: Will Miao Date: Tue, 12 May 2026 22:50:30 +0800 Subject: [PATCH] refactor(download-history): rename mark_not_downloaded to mark_as_deleted MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The method mark_not_downloaded() was misleading — it doesn't negate 'downloaded' history (the model was indeed downloaded before), but rather sets is_deleted_override = 1 to indicate the version was downloaded and subsequently deleted. This flag allows re-download when the 'skip previously downloaded' setting is enabled. Rename to mark_as_deleted() to accurately reflect its semantics. --- py/routes/handlers/misc_handlers.py | 4 ++-- py/services/downloaded_version_history_service.py | 2 +- tests/routes/test_api_snapshots.py | 2 +- tests/routes/test_misc_routes.py | 2 +- tests/services/test_downloaded_version_history_service.py | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/py/routes/handlers/misc_handlers.py b/py/routes/handlers/misc_handlers.py index 671d7950..73b8da72 100644 --- a/py/routes/handlers/misc_handlers.py +++ b/py/routes/handlers/misc_handlers.py @@ -2065,7 +2065,7 @@ class ModelLibraryHandler: file_path=file_path if isinstance(file_path, str) else None, ) else: - await history_service.mark_not_downloaded(model_type, model_version_id) + await history_service.mark_as_deleted(model_type, model_version_id) return web.json_response( { @@ -2151,7 +2151,7 @@ class ModelLibraryHandler: await persist() history_service = await self._get_download_history_service() - await history_service.mark_not_downloaded(found_type, model_version_id) + await history_service.mark_as_deleted(found_type, model_version_id) return web.json_response( { diff --git a/py/services/downloaded_version_history_service.py b/py/services/downloaded_version_history_service.py index 032a494e..00d0bc7d 100644 --- a/py/services/downloaded_version_history_service.py +++ b/py/services/downloaded_version_history_service.py @@ -206,7 +206,7 @@ class DownloadedVersionHistoryService: ) conn.commit() - async def mark_not_downloaded(self, model_type: str, version_id: int) -> None: + async def mark_as_deleted(self, model_type: str, version_id: int) -> None: normalized_type = _normalize_model_type(model_type) normalized_version_id = _normalize_int(version_id) if normalized_type is None or normalized_version_id is None: diff --git a/tests/routes/test_api_snapshots.py b/tests/routes/test_api_snapshots.py index 4452524b..7b83bd65 100644 --- a/tests/routes/test_api_snapshots.py +++ b/tests/routes/test_api_snapshots.py @@ -79,7 +79,7 @@ class FakeDownloadHistoryService: async def mark_downloaded(self, *_args, **_kwargs): return None - async def mark_not_downloaded(self, *_args, **_kwargs): + async def mark_as_deleted(self, *_args, **_kwargs): return None diff --git a/tests/routes/test_misc_routes.py b/tests/routes/test_misc_routes.py index 9e0543c2..5f7154b1 100644 --- a/tests/routes/test_misc_routes.py +++ b/tests/routes/test_misc_routes.py @@ -903,7 +903,7 @@ class FakeDownloadHistoryService: (model_type, version_id, model_id, source, file_path) ) - async def mark_not_downloaded(self, model_type, version_id): + async def mark_as_deleted(self, model_type, version_id): self.marked_not_downloaded.append((model_type, version_id)) diff --git a/tests/services/test_downloaded_version_history_service.py b/tests/services/test_downloaded_version_history_service.py index 3e58f73c..f6f75b89 100644 --- a/tests/services/test_downloaded_version_history_service.py +++ b/tests/services/test_downloaded_version_history_service.py @@ -30,7 +30,7 @@ async def test_download_history_roundtrip_and_manual_override(tmp_path: Path) -> assert await service.has_been_downloaded("lora", 101) is True assert await service.get_downloaded_version_ids("lora", 11) == [101] - await service.mark_not_downloaded("lora", 101) + await service.mark_as_deleted("lora", 101) assert await service.has_been_downloaded("lora", 101) is False assert await service.get_downloaded_version_ids("lora", 11) == []