From 476ecb742332233c91e65fddbcb2bb88167df86e Mon Sep 17 00:00:00 2001
From: Will Miao <13051207myq@gmail.com>
Date: Thu, 4 Sep 2025 22:07:07 +0800
Subject: [PATCH] fix(banner): ensure href attribute defaults to '#' for
 actions without a URL

---
 static/js/managers/BannerService.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/static/js/managers/BannerService.js b/static/js/managers/BannerService.js
index 808bfb12..2793198d 100644
--- a/static/js/managers/BannerService.js
+++ b/static/js/managers/BannerService.js
@@ -136,10 +136,10 @@ class BannerService {
 
         const actionsHtml = banner.actions ? banner.actions.map(action => {
             const actionAttribute = action.action ? `data-action="${action.action}"` : '';
-            const href = action.url ? `href="${action.url}"` : '#';
+            const href = action.url ? `href="${action.url}"` : 'href="#"';
             const target = action.url ? 'target="_blank" rel="noopener noreferrer"' : '';
             
-            return `<a ${href ? `href="${href}"` : ''} ${target} class="banner-action banner-action-${action.type}" ${actionAttribute}>
+            return `<a ${href} ${target} class="banner-action banner-action-${action.type}" ${actionAttribute}>
                 <i class="${action.icon}"></i>
                 <span>${action.text}</span>
             </a>`;