mirror of
https://github.com/willmiao/ComfyUI-Lora-Manager.git
synced 2026-03-24 06:32:12 -03:00
feat(model-cache): respect model name display preference
This commit is contained in:
41
tests/services/test_model_cache.py
Normal file
41
tests/services/test_model_cache.py
Normal file
@@ -0,0 +1,41 @@
|
||||
import pytest
|
||||
|
||||
from py.services.model_cache import ModelCache
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_name_sort_respects_file_name_display():
|
||||
items = [
|
||||
{"model_name": "Bravo", "file_name": "zulu", "folder": "", "size": 1, "modified": 1},
|
||||
{"model_name": "Alpha", "file_name": "alpha", "folder": "", "size": 1, "modified": 1},
|
||||
{"model_name": "Charlie", "file_name": "echo", "folder": "", "size": 1, "modified": 1},
|
||||
]
|
||||
|
||||
cache = ModelCache(raw_data=items, folders=[], name_display_mode="file_name")
|
||||
|
||||
sorted_items = await cache.get_sorted_data("name", "asc")
|
||||
|
||||
assert [item["file_name"] for item in sorted_items] == [
|
||||
"alpha",
|
||||
"echo",
|
||||
"zulu",
|
||||
]
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_update_name_display_mode_resorts_cached_name_order():
|
||||
items = [
|
||||
{"model_name": "Zulu", "file_name": "alpha", "folder": "", "size": 1, "modified": 1},
|
||||
{"model_name": "Alpha", "file_name": "zulu", "folder": "", "size": 1, "modified": 1},
|
||||
]
|
||||
|
||||
cache = ModelCache(raw_data=items, folders=[], name_display_mode="model_name")
|
||||
|
||||
initial = await cache.get_sorted_data("name", "asc")
|
||||
assert [item["model_name"] for item in initial] == ["Alpha", "Zulu"]
|
||||
|
||||
await cache.update_name_display_mode("file_name")
|
||||
|
||||
# The cached name sort should refresh immediately based on the new mode
|
||||
updated = await cache.get_sorted_data("name", "asc")
|
||||
assert [item["file_name"] for item in updated] == ["alpha", "zulu"]
|
||||
@@ -4,6 +4,7 @@ import os
|
||||
|
||||
import pytest
|
||||
|
||||
from py.services import service_registry
|
||||
from py.services.settings_manager import SettingsManager
|
||||
from py.utils import settings_paths
|
||||
|
||||
@@ -100,6 +101,38 @@ def test_delete_setting(manager):
|
||||
assert manager.get("example") is None
|
||||
|
||||
|
||||
def test_model_name_display_setting_notifies_scanners(tmp_path, monkeypatch):
|
||||
initial = {
|
||||
"libraries": {"default": {"folder_paths": {}, "default_lora_root": "", "default_checkpoint_root": "", "default_embedding_root": ""}},
|
||||
"active_library": "default",
|
||||
"model_name_display": "model_name",
|
||||
}
|
||||
|
||||
manager = _create_manager_with_settings(tmp_path, monkeypatch, initial)
|
||||
|
||||
class DummyScanner:
|
||||
def __init__(self):
|
||||
self.calls = []
|
||||
|
||||
async def on_model_name_display_changed(self, mode: str) -> None:
|
||||
self.calls.append(mode)
|
||||
|
||||
dummy_scanner = DummyScanner()
|
||||
|
||||
def fake_get_service_sync(cls, name):
|
||||
return dummy_scanner if name == "lora_scanner" else None
|
||||
|
||||
monkeypatch.setattr(
|
||||
service_registry.ServiceRegistry,
|
||||
"get_service_sync",
|
||||
classmethod(fake_get_service_sync),
|
||||
)
|
||||
|
||||
manager.set("model_name_display", "file_name")
|
||||
|
||||
assert dummy_scanner.calls == ["file_name"]
|
||||
|
||||
|
||||
def test_migrates_legacy_settings_file(tmp_path, monkeypatch):
|
||||
legacy_root = tmp_path / "legacy"
|
||||
legacy_root.mkdir()
|
||||
|
||||
Reference in New Issue
Block a user