alphard/ComfyUI-Lora-Manager
1
0
Fork 0
mirror of https://github.com/willmiao/ComfyUI-Lora-Manager.git synced 2026-10-03 08:45:31 -03:00
Code Issues Packages Projects Releases Wiki Activity

fix(downloads): route unknown checkpoint baseModels to diffusion models by default

Browse Source 
CivitAI labels new DiT architectures (MiniMax H3, future Flux/Wan/Qwen
variants) as model.type "Checkpoint" with plain "Model" file entries,
so the DIFFUSION_MODEL_BASE_MODELS allowlist could never keep up and
such downloads were mis-routed to the checkpoint roots (e.g. model
2877206 / version 3374439). The set of true full-checkpoint families is
closed, so the baseModel fallback is inverted:

1. file type UNet/Diffusion Model -> unet (unchanged)
2. baseModel in DIFFUSION_MODEL_BASE_MODELS (now incl. MiniMax H3) -> unet
3. baseModel in new CHECKPOINT_BASE_MODELS (SD 1.x/2.x/3.x, SDXL, Pony,
   Illustrious, NoobAI) -> checkpoint
4. unknown/empty baseModel -> new unknown_base_model_routing setting,
   defaulting to diffusion models

The setting is exposed under Settings > Downloads, validated in
SettingsManager, and threaded into both the download manager and the
download routing endpoint so they keep agreeing.
This commit is contained in:
Will Miao
2026-10-02 09:58:01 +08:00
parent 2193ec8f38
commit 3aa32120df
22 changed files with 270 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/services/test_settings_manager.py
+15
View File
@@ -1300,6 +1300,21 @@ def test_setting_download_skip_base_models_normalizes_string_input(manager):
assert manager.get("download_skip_base_models") == ["SDXL 1.0", "Pony"]
def test_unknown_base_model_routing_defaults_to_diffusion_model(manager):
assert manager.get("unknown_base_model_routing") == "diffusion_model"
def test_unknown_base_model_routing_is_normalized(manager):
manager.set("unknown_base_model_routing", "CHECKPOINT")
assert manager.get("unknown_base_model_routing") == "checkpoint"
manager.set("unknown_base_model_routing", "bogus")
assert manager.get("unknown_base_model_routing") == "diffusion_model"
manager.set("unknown_base_model_routing", None)
assert manager.get("unknown_base_model_routing") == "diffusion_model"
def test_skip_previously_downloaded_model_versions_defaults_false(manager):
assert manager.get_skip_previously_downloaded_model_versions() is False