alphard/ComfyUI-Lora-Manager
1
0
Fork 0
mirror of https://github.com/willmiao/ComfyUI-Lora-Manager.git synced 2026-03-25 15:15:44 -03:00
Code Issues Packages Projects Releases Wiki Activity

fix: avoid scanner.py false positives in test fixtures

Browse Source 
Replace NODE_CLASS_MAPPINGS.update({...}) with direct assignment
to prevent ComfyUI Manager scanner from detecting test mock nodes
as actual plugin nodes.

The scanner.py pattern '_CLASS_MAPPINGS\.update\s*\(\s*{([^}]*)}\s*\)'
was matching test fixtures that use .update() to register mock nodes,
causing false positive conflict warnings.
This commit is contained in:
Will Miao
2026-01-14 10:21:44 +08:00
parent bc08a45214
commit 394eebe070
1 changed files with 41 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
tests/metadata_collector/conftest.py
View File

@@ -42,22 +42,26 @@ def populated_registry(metadata_registry):
class VAEDecode: # type: ignore[too-many-ancestors] class VAEDecode: # type: ignore[too-many-ancestors]
__name__ = "VAEDecode" __name__ = "VAEDecode"
nodes.NODE_CLASS_MAPPINGS.update( # Direct assignment to avoid scanner.py false positive
{ # (scanner.py matches _CLASS_MAPPINGS.update({...}) pattern)
"TSC_EfficientLoader": TSC_EfficientLoader, nodes.NODE_CLASS_MAPPINGS["TSC_EfficientLoader"] = TSC_EfficientLoader
"SamplerCustomAdvanced": SamplerCustomAdvanced, nodes.NODE_CLASS_MAPPINGS["SamplerCustomAdvanced"] = SamplerCustomAdvanced
"BasicScheduler": BasicScheduler, nodes.NODE_CLASS_MAPPINGS["BasicScheduler"] = BasicScheduler
"KSamplerSelect": KSamplerSelect, nodes.NODE_CLASS_MAPPINGS["KSamplerSelect"] = KSamplerSelect
"CFGGuider": CFGGuider, nodes.NODE_CLASS_MAPPINGS["CFGGuider"] = CFGGuider
"CLIPTextEncode": CLIPTextEncode, nodes.NODE_CLASS_MAPPINGS["CLIPTextEncode"] = CLIPTextEncode
"VAEDecode": VAEDecode, nodes.NODE_CLASS_MAPPINGS["VAEDecode"] = VAEDecode
}
)
prompt_graph = { prompt_graph = {
"loader": {"class_type": "TSC_EfficientLoader", "inputs": {}}, "loader": {"class_type": "TSC_EfficientLoader", "inputs": {}},
"encode_pos": {"class_type": "CLIPTextEncode", "inputs": {"text": "A castle on a hill"}}, "encode_pos": {
"encode_neg": {"class_type": "CLIPTextEncode", "inputs": {"text": "low quality"}}, "class_type": "CLIPTextEncode",
"inputs": {"text": "A castle on a hill"},
},
"encode_neg": {
"class_type": "CLIPTextEncode",
"inputs": {"text": "low quality"},
},
"cfg_guider": { "cfg_guider": {
"class_type": "CFGGuider", "class_type": "CFGGuider",
"inputs": { "inputs": {
@@ -109,7 +113,9 @@ def populated_registry(metadata_registry):
"positive": "A castle on a hill", "positive": "A castle on a hill",
"negative": "low quality", "negative": "low quality",
} }
metadata_registry.record_node_execution("loader", "TSC_EfficientLoader", loader_inputs, None) metadata_registry.record_node_execution(
"loader", "TSC_EfficientLoader", loader_inputs, None
)
loader_outputs = [ loader_outputs = [
( (
None, None,
@@ -121,16 +127,28 @@ def populated_registry(metadata_registry):
{}, {},
) )
] ]
metadata_registry.update_node_execution("loader", "TSC_EfficientLoader", loader_outputs) metadata_registry.update_node_execution(
"loader", "TSC_EfficientLoader", loader_outputs
)
# Positive and negative prompt encoders # Positive and negative prompt encoders
metadata_registry.record_node_execution("encode_pos", "CLIPTextEncode", {"text": "A castle on a hill"}, None) metadata_registry.record_node_execution(
metadata_registry.update_node_execution("encode_pos", "CLIPTextEncode", [(pos_conditioning,)]) "encode_pos", "CLIPTextEncode", {"text": "A castle on a hill"}, None
metadata_registry.record_node_execution("encode_neg", "CLIPTextEncode", {"text": "low quality"}, None) )
metadata_registry.update_node_execution("encode_neg", "CLIPTextEncode", [(neg_conditioning,)]) metadata_registry.update_node_execution(
"encode_pos", "CLIPTextEncode", [(pos_conditioning,)]
)
metadata_registry.record_node_execution(
"encode_neg", "CLIPTextEncode", {"text": "low quality"}, None
)
metadata_registry.update_node_execution(
"encode_neg", "CLIPTextEncode", [(neg_conditioning,)]
)
# CFG guider and scheduler nodes # CFG guider and scheduler nodes
metadata_registry.record_node_execution("cfg_guider", "CFGGuider", {"cfg": 7.5}, None) metadata_registry.record_node_execution(
"cfg_guider", "CFGGuider", {"cfg": 7.5}, None
)
metadata_registry.record_node_execution( metadata_registry.record_node_execution(
"scheduler", "scheduler",
"BasicScheduler", "BasicScheduler",
@@ -148,7 +166,9 @@ def populated_registry(metadata_registry):
"negative": neg_conditioning, "negative": neg_conditioning,
"latent_image": {"samples": latent_samples}, "latent_image": {"samples": latent_samples},
} }
metadata_registry.record_node_execution("sampler", "SamplerCustomAdvanced", sampler_inputs, None) metadata_registry.record_node_execution(
"sampler", "SamplerCustomAdvanced", sampler_inputs, None
)
# VAEDecode outputs image data # VAEDecode outputs image data
metadata_registry.record_node_execution("vae", "VAEDecode", {}, None) metadata_registry.record_node_execution("vae", "VAEDecode", {}, None)