From 3849f7eef970c6ff7f6d3097c303c5504adc1469 Mon Sep 17 00:00:00 2001
From: Will Miao <willmiao.dev@gmail.com>
Date: Wed, 19 Nov 2025 19:16:40 +0800
Subject: [PATCH] feat(metadata): improve civitai deletion detection logic

- Track when Civitai API returns "Model not found" for default provider
- Use dedicated flag instead of error string comparison for deletion detection
- Ensure archive-sourced models don't get marked as deleted
- Add test coverage for archive source deletion flag behavior
- Fix deletion flag logic to properly handle provider fallback scenarios
---
 py/services/metadata_sync_service.py         | 13 ++++++--
 tests/services/test_metadata_sync_service.py | 35 ++++++++++++++++++++
 2 files changed, 46 insertions(+), 2 deletions(-)

diff --git a/py/services/metadata_sync_service.py b/py/services/metadata_sync_service.py
index 6a302bd1..d4a0b811 100644
--- a/py/services/metadata_sync_service.py
+++ b/py/services/metadata_sync_service.py
@@ -214,6 +214,7 @@ class MetadataSyncService:
             metadata_provider: Optional[MetadataProviderProtocol] = None
             provider_used: Optional[str] = None
             last_error: Optional[str] = None
+            civitai_api_not_found = False
 
             for provider_name, provider in provider_attempts:
                 try:
@@ -228,19 +229,24 @@ class MetadataSyncService:
                 if provider_name == "sqlite":
                     sqlite_attempted = True
 
+                is_default_provider = provider_name is None
+
                 if civitai_metadata_candidate:
                     civitai_metadata = civitai_metadata_candidate
                     metadata_provider = provider
                     provider_used = provider_name
                     break
 
+                if is_default_provider and error == "Model not found":
+                    civitai_api_not_found = True
+
                 last_error = error or last_error
 
             if civitai_metadata is None or metadata_provider is None:
                 if sqlite_attempted:
                     model_data["db_checked"] = True
 
-                if last_error == "Model not found":
+                if civitai_api_not_found:
                     model_data["from_civitai"] = False
                     model_data["civitai_deleted"] = True
                     model_data["db_checked"] = sqlite_attempted or (enable_archive and model_data.get("db_checked", False))
@@ -266,7 +272,10 @@ class MetadataSyncService:
                 return False, error_msg
 
             model_data["from_civitai"] = True
-            model_data["civitai_deleted"] = civitai_metadata.get("source") == "archive_db" or civitai_metadata.get("source") == "civarchive"
+            if provider_used is None:
+                model_data["civitai_deleted"] = False
+            elif civitai_api_not_found:
+                model_data["civitai_deleted"] = True
             model_data["db_checked"] = enable_archive and (
                 civitai_metadata.get("source") == "archive_db" or sqlite_attempted
             )
diff --git a/tests/services/test_metadata_sync_service.py b/tests/services/test_metadata_sync_service.py
index 6d44629d..5d6c7e6b 100644
--- a/tests/services/test_metadata_sync_service.py
+++ b/tests/services/test_metadata_sync_service.py
@@ -179,6 +179,39 @@ async def test_fetch_and_update_model_success_updates_cache(tmp_path):
     update_cache.assert_awaited_once()
 
 
+@pytest.mark.asyncio
+async def test_fetch_and_update_model_keeps_deleted_flag_false_for_archive_source(tmp_path):
+    helpers = build_service()
+
+    civitai_payload = {
+        "source": "archive_db",
+        "model": {"name": "Recovered", "description": "", "tags": ["tag"]},
+        "images": [],
+        "baseModel": "sd15",
+    }
+    helpers.default_provider.get_model_by_hash.return_value = (civitai_payload, None)
+
+    model_path = tmp_path / "model.safetensors"
+    model_data = {
+        "model_name": "Local",
+        "folder": "root",
+        "file_path": str(model_path),
+    }
+    update_cache = AsyncMock(return_value=True)
+
+    ok, error = await helpers.service.fetch_and_update_model(
+        sha256="abc",
+        file_path=str(model_path),
+        model_data=model_data,
+        update_cache_func=update_cache,
+    )
+
+    assert ok and error is None
+    assert model_data["metadata_source"] == "archive_db"
+    assert model_data["civitai_deleted"] is False
+    update_cache.assert_awaited_once()
+
+
 @pytest.mark.asyncio
 async def test_fetch_and_update_model_handles_missing_remote_metadata(tmp_path):
     helpers = build_service()
@@ -301,6 +334,7 @@ async def test_fetch_and_update_model_prefers_civarchive_for_deleted_models(tmp_
     civarchive_provider.get_model_by_hash.assert_awaited_once_with("deadbeef")
     update_cache.assert_awaited()
     assert model_data["metadata_source"] == "civarchive"
+    assert model_data["civitai_deleted"] is True
     helpers.metadata_manager.save_metadata.assert_awaited()
 
 
@@ -359,6 +393,7 @@ async def test_fetch_and_update_model_falls_back_to_sqlite_after_civarchive_fail
     assert sqlite_provider.get_model_by_hash.await_count == 1
     assert model_data["metadata_source"] == "archive_db"
     assert model_data["db_checked"] is True
+    assert model_data["civitai_deleted"] is True
     assert provider_selector.await_args_list[0].args == ("civarchive_api",)
     assert provider_selector.await_args_list[1].args == ("sqlite",)
     update_cache.assert_awaited()