alphard/ComfyUI-Lora-Manager
1
0
Fork 0
mirror of https://github.com/willmiao/ComfyUI-Lora-Manager.git synced 2026-03-25 23:25:43 -03:00
Code Issues Packages Projects Releases Wiki Activity

perf(usage-stats): prevent unnecessary writes when idle

Browse Source 
- Add is_dirty flag to track if statistics have changed
- Only write stats file when data actually changes
- Add enable_usage_statistics setting in ComfyUI settings
- Skip backend requests when usage statistics is disabled
- Fix standalone mode compatibility for MetadataRegistry

Fixes #826
This commit is contained in:
Will Miao
2026-02-23 14:00:00 +08:00
parent ec76ac649b
commit 26b139884c
3 changed files with 93 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
web/comfyui/settings.js
View File

@@ -16,6 +16,9 @@ const PROMPT_TAG_AUTOCOMPLETE_DEFAULT = true;
const TAG_SPACE_REPLACEMENT_SETTING_ID = "loramanager.tag_space_replacement";
const TAG_SPACE_REPLACEMENT_DEFAULT = false;
const USAGE_STATISTICS_SETTING_ID = "loramanager.usage_statistics";
const USAGE_STATISTICS_DEFAULT = true;
// ============================================================================
// Helper Functions
// ============================================================================
@@ -124,6 +127,32 @@ const getTagSpaceReplacementPreference = (() => {
};
})();
const getUsageStatisticsPreference = (() => {
let settingsUnavailableLogged = false;
return () => {
const settingManager = app?.extensionManager?.setting;
if (!settingManager || typeof settingManager.get !== "function") {
if (!settingsUnavailableLogged) {
console.warn("LoRA Manager: settings API unavailable, using default usage statistics setting.");
settingsUnavailableLogged = true;
}
return USAGE_STATISTICS_DEFAULT;
}
try {
const value = settingManager.get(USAGE_STATISTICS_SETTING_ID);
return value ?? USAGE_STATISTICS_DEFAULT;
} catch (error) {
if (!settingsUnavailableLogged) {
console.warn("LoRA Manager: unable to read usage statistics setting, using default.", error);
settingsUnavailableLogged = true;
}
return USAGE_STATISTICS_DEFAULT;
}
};
})();
// ============================================================================
// Register Extension with All Settings
// ============================================================================
@@ -168,6 +197,14 @@ app.registerExtension({
tooltip: "When enabled, tag names with underscores will have them replaced with spaces when inserted (e.g., 'blonde_hair' becomes 'blonde hair').",
category: ["LoRA Manager", "Autocomplete", "Tag Formatting"],
},
{
id: USAGE_STATISTICS_SETTING_ID,
name: "Enable usage statistics tracking",
type: "boolean",
defaultValue: USAGE_STATISTICS_DEFAULT,
tooltip: "When enabled, LoRA Manager will track model usage statistics during workflow execution. Disabling this will prevent unnecessary disk writes.",
category: ["LoRA Manager", "Statistics", "Usage Tracking"],
},
],
});
@@ -175,4 +212,4 @@ app.registerExtension({
// Exports
// ============================================================================
export { getWheelSensitivity, getAutoPathCorrectionPreference, getPromptTagAutocompletePreference, getTagSpaceReplacementPreference };
export { getWheelSensitivity, getAutoPathCorrectionPreference, getPromptTagAutocompletePreference, getTagSpaceReplacementPreference, getUsageStatisticsPreference };