fix(recipes): reject the empty-hash placeholder when resolving LoRA hashes

The SHA256 of an empty byte string (written by repackaging tools into
safetensors metadata, or produced by hashing an empty/unreadable file)
was previously resolved against CivitAI's by-hash API, which can contain
polluted entries for it (e.g. a broken SD 1.5 LoRA whose AutoV3 equals
the placeholder) and falsely attributed the wrong model to a recipe.

Guard all lookup paths for the 10/12/64-char AutoV2/AutoV3/full-SHA256
spellings: CivitaiClient.get_model_by_hash/_fetch_version_by_hash return
not-found without a request, and ModelHashIndex ignores the placeholder
in has_hash/get_path/add_autov3.

The Automatic1111 metadata parser keeps the LoRA item itself when its
hash is the placeholder: it matches by filename locally, or retains the
entry with an empty hash flagged hashInvalid (unresolvable-hash state in
the UI, with reconnect as the remedy) instead of dropping it or resolving
it to a polluted CivitAI entry.
This commit is contained in:
Will Miao
2026-09-01 20:40:21 +08:00
parent 39e7c1376c
commit 1fd7cc0123
8 changed files with 235 additions and 7 deletions
+29
View File
@@ -789,3 +789,32 @@ async def test_get_creator_model_count_never_raises(downloader):
client = await CivitaiClient.get_instance()
assert await client.get_creator_model_count("pixel") is None
@pytest.mark.parametrize(
"placeholder_hash",
[
"e3b0c44298", # AutoV2 (10 chars)
"e3b0c44298fc", # AutoV3 (12 chars)
"e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855", # full SHA256
],
)
async def test_get_model_by_hash_rejects_empty_placeholder_without_request(downloader, placeholder_hash):
"""The empty-hash placeholder must never be resolved via the by-hash API:
CivitAI's index can contain polluted entries for it (e.g. a broken SD 1.5
LoRA whose AutoV3 equals the placeholder)."""
requested = []
async def fake_make_request(method, url, use_auth=True, **kwargs):
requested.append(url)
return True, {}
downloader.make_request = fake_make_request
client = await CivitaiClient.get_instance()
result, error = await client.get_model_by_hash(placeholder_hash)
assert result is None
assert error == "Model not found"
assert requested == []