fix: keep bypass/mute state on frontend 1.53+ node shell state (#1123)

ComfyUI frontend 1.53 turned LGraphNode.mode into a prototype accessor
backed by node._state, and serialize() now reads that state directly.
Redefining mode on the instance shadowed the setter, so bypass/mute
never reached the serialized workflow and silently reverted to Always
on save/reload or workflow tab switch.

Add interceptModeChange() in web/comfyui/utils.js: it delegates to the
prototype accessor when one exists (observing changes only), and falls
back to the legacy closure accessor on older frontends. Use it in
lora_loader.js and in the Vue widgets' setupModeChangeHandler, which
covers the LoRA provider/aggregator nodes with the same latent bug.
This commit is contained in:
Will Miao
2026-09-25 18:12:01 +08:00
parent dae18b3d1d
commit 067e605e75
8 changed files with 360 additions and 120 deletions
+9 -17
View File
@@ -7,6 +7,9 @@
* - Lora Cycler (LoraManager)
*/
// @ts-ignore
import { interceptModeChange } from '../../web/comfyui/utils.js'
/**
* List of node types that act as LoRA providers in the workflow chain.
* These nodes can be traversed when collecting active LoRAs and can trigger
@@ -120,8 +123,11 @@ export function isNodeActive(mode: number | undefined): boolean {
/**
* Setup a mode change handler for a node.
*
* Intercepts the mode property setter to trigger a callback when the mode changes.
* This is needed because ComfyUI sets the mode property directly without using a setter.
* Delegates to `interceptModeChange`, which observes the mode property
* without shadowing the frontend's own `mode` accessor. Since ComfyUI
* frontend 1.53, `mode` is backed by shell state (`node._state.mode`) that
* serialization reads directly — redefining the property on the instance
* would silently revert bypass/mute on save/reload.
*
* @param node - The node to set up the handler for
* @param onModeChange - Callback function called when mode changes (receives newMode and oldMode)
@@ -130,21 +136,7 @@ export function setupModeChangeHandler(
node: any,
onModeChange: (newMode: number, oldMode: number) => void
): void {
let _mode = node.mode;
Object.defineProperty(node, 'mode', {
get() {
return _mode;
},
set(value: number) {
const oldValue = _mode;
_mode = value;
if (oldValue !== value) {
onModeChange(value, oldValue);
}
}
});
interceptModeChange(node, onModeChange);
}
/**