alphard/ComfyUI-Lora-Manager
1
0
Fork 0
mirror of https://github.com/willmiao/ComfyUI-Lora-Manager.git synced 2026-10-12 12:32:11 -03:00
Code Issues Packages Projects Releases Wiki Activity

fix(scanner): verify recorded folders per entry, not per scan (#1145)

Browse Source 
`_reconcile_cache()` replaced the recorded folder list only when *nothing* was left
unverified: one switched-off drive, one directory `os.walk` could not enter, or one
symlink whose target was gone, and the whole list fell back to a union with what
the walk found. A folder moved with a file manager therefore stayed in the sidebar
for good — the walk kept adding the new location while the old entry was never
dropped, a restart re-hydrated the union from SQLite, and the ghost could not be
deleted in the UI either because its directory was gone.

* `_UnreachablePaths.covers_folder()` answers "could this specific entry have been
  read?" for a library-relative folder: it is kept only while a directory the walk
  failed to enter (or an offline symlink) may still hold it. A root that is
  unreadable *as a whole* deliberately does not count: library-relative names carry
  no root, so a missing drive would trivially cover every entry and no ghost could
  ever be cleared. Its folders still show while they hold cached models
  (`get_all_folders()` unions the model-derived folders) and a genuinely empty one
  comes back the next time that root is walked.
* The merge keeps today's union for a scoped scan, and for a root-scoped scan that
  does not cover every root: those cannot speak for the roots they were not asked
  about. Asking for every root is a full refresh and cleans again.

Verified: a folder moved externally is dropped while another root is offline, the
offline root keeps its own folders and cached models, and a scoped scan still never
drops a folder of a root it did not scan. The Windows-only half of this (a
backslash `os.sep` making the configured twin shadow the live root, so deleted
models were never pruned) is now reproduced in CI by patching `os.sep` instead of
needing a Windows runner.
This commit is contained in:
Will Miao
2026-10-12 09:31:17 +08:00
parent fadad1b507
commit 0508daa0fb
3 changed files with 243 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/plans/issue-1108-scoped-scan.md
+5 -3
View File
@@ -22,9 +22,11 @@ Implementation notes / deviations from the draft below:
they are outside every configured root prefix. The `root_unreachable` path therefore covers the
*mid-session* case (drive switched off while LM runs), which is the workflow that motivated the
issue; both paths keep the entries, which is what matters.
* Known limitation to keep in mind: after a scoped scan (or one with unreadable paths) the recorded
empty-folder list is unioned instead of replaced, so an empty folder deleted on disk can linger in
the sidebar until the next full refresh. Models are unaffected.
* Known limitation to keep in mind: after a *scoped* scan the recorded empty-folder list is unioned
instead of replaced, so an empty folder deleted on disk can linger in the sidebar until the next
full refresh. A full refresh keeps only the entries a specific unreadable area (a directory
`os.walk` could not enter, an offline symlink) may still hold, so one switched-off drive no longer
keeps every other root's ghosts alive (issue #1145).
## TL;DR (For humans)