fix(autocomplete): sync active filters via server-side store (#1091)

The LoRA Manager page kept its active filters in localStorage, which the ComfyUI-side autocomplete read directly. When the two run in different browsers, origins, or the ComfyUI Desktop Electron shell, localStorage is not shared and the active-filters search silently did nothing. The manager page now mirrors its filter state to a server-side in-memory store (PUT /api/lm/{prefix}/active-filters), pushed on every change via a storage-listener hook and once on page load. The autocomplete widget sends only use_active_filters=true, and the relative-paths endpoint injects the stored filters into the search, with explicit query params taking precedence.
2026-09-21 03:01:27 -03:00 · 2026-09-02 14:33:44 +08:00
parent 6b41c3bbb4
commit 00095a5398
14 changed files with 952 additions and 112 deletions
@@ -0,0 +1,128 @@
+import pytest
+
+from py.services.active_filters_store import (
+    ActiveFiltersStore,
+    active_filters_to_query_kwargs,
+)
+
+
+@pytest.fixture(autouse=True)
+def reset_store():
+    ActiveFiltersStore.reset_instance()
+    yield
+    ActiveFiltersStore.reset_instance()
+
+
+def test_store_roundtrip():
+    store = ActiveFiltersStore.get_instance()
+    payload = {
+        "activeFolder": "SD_XL",
+        "recursiveSearch": False,
+        "filters": {"baseModel": ["SDXL 1.0"], "tags": {"anime": "include"}},
+    }
+    store.set_filters("loras", payload)
+
+    assert store.get_filters("loras") == payload
+    assert store.get_filters("checkpoints") is None
+
+
+def test_store_sanitizes_payload():
+    store = ActiveFiltersStore.get_instance()
+    store.set_filters(
+        "loras",
+        {
+            "activeFolder": "anime",
+            "recursiveSearch": True,
+            "filters": {"baseModel": [], "unexpected": "dropped"},
+            "extra": "dropped",
+        },
+    )
+
+    stored = store.get_filters("loras")
+    assert stored == {
+        "activeFolder": "anime",
+        "recursiveSearch": True,
+        "filters": {"baseModel": []},
+    }
+
+
+def test_store_non_dict_filters_become_none():
+    store = ActiveFiltersStore.get_instance()
+    store.set_filters("loras", {"activeFolder": None, "filters": "garbage"})
+
+    assert store.get_filters("loras")["filters"] is None
+
+
+def test_store_clear():
+    store = ActiveFiltersStore.get_instance()
+    store.set_filters("loras", {"activeFolder": "x"})
+    store.clear("loras")
+
+    assert store.get_filters("loras") is None
+
+
+def test_mapping_empty_payload():
+    assert active_filters_to_query_kwargs(None) == {}
+    assert active_filters_to_query_kwargs({}) == {}
+    assert active_filters_to_query_kwargs({"activeFolder": None}) == {"recursive": True}
+
+
+def test_mapping_folder():
+    assert active_filters_to_query_kwargs(
+        {"activeFolder": "SD_XL", "recursiveSearch": True}
+    ) == {"folder": "SD_XL", "recursive": True}
+
+
+def test_mapping_root_folder_non_recursive():
+    # Root folder with recursion disabled matches only root-level files
+    assert active_filters_to_query_kwargs(
+        {"activeFolder": None, "recursiveSearch": False}
+    ) == {"folder": "", "recursive": False}
+
+
+def test_mapping_legacy_null_string_folder():
+    assert active_filters_to_query_kwargs(
+        {"activeFolder": "null", "recursiveSearch": True}
+    ) == {"recursive": True}
+
+
+def test_mapping_full_filters():
+    kwargs = active_filters_to_query_kwargs(
+        {
+            "activeFolder": "anime",
+            "recursiveSearch": True,
+            "filters": {
+                "baseModel": ["SDXL 1.0", "Pony"],
+                "tags": {"anime": "include", "3d": "exclude", "junk": "ignored"},
+                "autoTags": {"cute": "include"},
+                "modelTypes": ["LoRA"],
+                "tagLogic": "all",
+                "license": {"noCredit": "include", "allowSelling": "exclude"},
+            },
+        }
+    )
+
+    assert kwargs == {
+        "folder": "anime",
+        "recursive": True,
+        "base_models": ["SDXL 1.0", "Pony"],
+        "tags": {"anime": "include", "3d": "exclude"},
+        "auto_tags": {"cute": "include"},
+        "model_types": ["LoRA"],
+        "tag_logic": "all",
+        "credit_required": False,
+        "allow_selling_generated_content": False,
+    }
+
+
+def test_mapping_license_exclude_variants():
+    kwargs = active_filters_to_query_kwargs(
+        {
+            "filters": {
+                "license": {"noCredit": "exclude", "allowSelling": "include"},
+            },
+        }
+    )
+
+    assert kwargs["credit_required"] is True
+    assert kwargs["allow_selling_generated_content"] is True